[clang] [llvm] [clang][CodeGen] Generate follow-up metadata for loops in correct format (PR #131985)

[Ryotaro Kasuga via llvm-commits]

================
@@ -44,23 +44,19 @@ MDNode *LoopInfo::createPipeliningMetadata(const LoopAttributes &Attrs,
   else if (Attrs.PipelineInitiationInterval != 0)
     Enabled = true;
 
+  SmallVector<Metadata *, 4> Args;
+  Args.append(LoopProperties.begin(), LoopProperties.end());
+
   if (Enabled != true) {
-    SmallVector<Metadata *, 4> NewLoopProperties;
     if (Enabled == false) {
-      NewLoopProperties.append(LoopProperties.begin(), LoopProperties.end());
-      NewLoopProperties.push_back(
+      Args.push_back(
           MDNode::get(Ctx, {MDString::get(Ctx, "llvm.loop.pipeline.disable"),
                             ConstantAsMetadata::get(ConstantInt::get(
                                 llvm::Type::getInt1Ty(Ctx), 1))}));
-      LoopProperties = NewLoopProperties;
----------------
kasuga-fj wrote:

What about other transformations, e.g., vectorization?
https://github.com/llvm/llvm-project/blob/ce8febb0befe41694b9d83c14dcfb831a82489ff/clang/lib/CodeGen/CGLoopInfo.cpp#L213-L220

I just looked for it and found an issue that might be caused by this.
https://github.com/llvm/llvm-project/issues/75839

https://github.com/llvm/llvm-project/pull/131985