[flang] [llvm] [flang][llvm][OpenMP][OpenACC] Add implicit casts to omp.atomic and acc.atomic (PR #131603)
via llvm-commits
llvm-commits at lists.llvm.org
Sun Mar 23 22:28:09 PDT 2025
================
@@ -386,6 +442,7 @@ void genOmpAccAtomicRead(Fortran::lower::AbstractConverter &converter,
fir::getBase(converter.genExprAddr(fromExpr, stmtCtx));
mlir::Value toAddress = fir::getBase(converter.genExprAddr(
*Fortran::semantics::GetExpr(assignmentStmtVariable), stmtCtx));
+ emitImplicitCast(converter, loc, fromAddress, toAddress, elementType);
----------------
NimishMishra wrote:
> I think this restriction could be relaxed if Michael is able to land his patch because with his patch applied these bugs seemed to be handled correctly (although there may perhaps be some edge case where clang casting rules are not appropriate for Fortran, maybe between complex and real?).
Yes that is indeed the case. Is it okay with you if we wait a while (say 1 or 2 weeks) to allow progress on that patch, and then take a call? Another alternative is that we go ahead with atomic read and atomic write for now, and emit a TODO for atomic capture.
https://github.com/llvm/llvm-project/pull/131603
More information about the llvm-commits
mailing list