[llvm] [Analysis] Avoid repeated hash lookups (NFC) (PR #132512)
via llvm-commits
llvm-commits at lists.llvm.org
Fri Mar 21 20:54:15 PDT 2025
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-llvm-analysis
Author: Kazu Hirata (kazutakahirata)
<details>
<summary>Changes</summary>
---
Full diff: https://github.com/llvm/llvm-project/pull/132512.diff
1 Files Affected:
- (modified) llvm/lib/Analysis/IRSimilarityIdentifier.cpp (+3-4)
``````````diff
diff --git a/llvm/lib/Analysis/IRSimilarityIdentifier.cpp b/llvm/lib/Analysis/IRSimilarityIdentifier.cpp
index e1daf02ee6bba..ca011362702ac 100644
--- a/llvm/lib/Analysis/IRSimilarityIdentifier.cpp
+++ b/llvm/lib/Analysis/IRSimilarityIdentifier.cpp
@@ -728,11 +728,10 @@ bool IRSimilarityCandidate::compareAssignmentMapping(
for (unsigned OtherVal : ValueMappingIt->second) {
if (OtherVal == InstValB)
continue;
- if (!ValueNumberMappingA.contains(OtherVal))
+ auto OtherValIt = ValueNumberMappingA.find(OtherVal);
+ if (OtherValIt == ValueNumberMappingA.end())
continue;
- if (!ValueNumberMappingA[OtherVal].contains(InstValA))
- continue;
- ValueNumberMappingA[OtherVal].erase(InstValA);
+ OtherValIt->second.erase(InstValA);
}
ValueNumberMappingA.erase(ValueMappingIt);
std::tie(ValueMappingIt, WasInserted) = ValueNumberMappingA.insert(
``````````
</details>
https://github.com/llvm/llvm-project/pull/132512
More information about the llvm-commits
mailing list