[clang] [llvm] [HLSL] Implement dot2add intrinsic (PR #131237)
    Sumit Agarwal via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Fri Mar 21 18:23:34 PDT 2025
    
    
  
================
@@ -2473,11 +2473,9 @@ bool SemaHLSL::CheckBuiltinFunctionCall(unsigned BuiltinID, CallExpr *TheCall) {
     break;
   }
   case Builtin::BI__builtin_hlsl_dot2add: {
-    // Check number of arguments should be 3
     if (SemaRef.checkArgCount(TheCall, 3))
       return true;
 
-    // Check first two arguments are vector of length 2 with half data type
     auto checkHalfVectorOfSize2 = [](clang::QualType PassedType) -> bool {
----------------
sumitsays wrote:
Makes sense. I am thinking on it a bit stretched: Now we don't need to do any semantics check (just need to set the type) because we are explicitly specifying the exact overload.
Isn't it? 
https://github.com/llvm/llvm-project/pull/131237
    
    
More information about the llvm-commits
mailing list