[clang] [llvm] [HLSL] Implement dot2add intrinsic (PR #131237)

[Farzon Lotfi via llvm-commits]

================
@@ -2473,11 +2473,9 @@ bool SemaHLSL::CheckBuiltinFunctionCall(unsigned BuiltinID, CallExpr *TheCall) {
     break;
   }
   case Builtin::BI__builtin_hlsl_dot2add: {
-    // Check number of arguments should be 3
     if (SemaRef.checkArgCount(TheCall, 3))
       return true;
 
-    // Check first two arguments are vector of length 2 with half data type
     auto checkHalfVectorOfSize2 = [](clang::QualType PassedType) -> bool {
----------------
farzonl wrote:

So now that this isnt void(...) and you defined the `Prototype` as `float(_ExtVector<2, _Float16>,_ExtVector<2, _Float16>, float)` I don't think we need these sema checks anymore. If you delete\comment this out I would expect your sema checks to still pass.

https://github.com/llvm/llvm-project/pull/131237