[llvm] [IR][JumpThreading] Fix infinite recursion on compare self-reference [updated] (PR #129501)

[via llvm-commits]

github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff f745cb68f1adae854fe1ff7cc43b4bbe36db3ac2 a48843869e667e9874379669656877a1c67a99f2 --extensions cpp -- llvm/lib/Transforms/Scalar/JumpThreading.cpp
``````````

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/llvm/lib/Transforms/Scalar/JumpThreading.cpp b/llvm/lib/Transforms/Scalar/JumpThreading.cpp
index 0dc2f832d4..68186687c4 100644
--- a/llvm/lib/Transforms/Scalar/JumpThreading.cpp
+++ b/llvm/lib/Transforms/Scalar/JumpThreading.cpp
@@ -1525,10 +1525,14 @@ Constant *JumpThreadingPass::evaluateOnPredecessorEdge(BasicBlock *BB,
   // instructions in unreachable code and check before going into recursion.
   if (CmpInst *CondCmp = dyn_cast<CmpInst>(V)) {
     if (CondCmp->getParent() == BB) {
-      Constant *Op0 = CondCmp->getOperand(0) == CondCmp ? nullptr :
-          evaluateOnPredecessorEdge(BB, PredPredBB, CondCmp->getOperand(0), DL);
-      Constant *Op1 = CondCmp->getOperand(1) == CondCmp ? nullptr :
-          evaluateOnPredecessorEdge(BB, PredPredBB, CondCmp->getOperand(1), DL);
+      Constant *Op0 = CondCmp->getOperand(0) == CondCmp
+                          ? nullptr
+                          : evaluateOnPredecessorEdge(
+                                BB, PredPredBB, CondCmp->getOperand(0), DL);
+      Constant *Op1 = CondCmp->getOperand(1) == CondCmp
+                          ? nullptr
+                          : evaluateOnPredecessorEdge(
+                                BB, PredPredBB, CondCmp->getOperand(1), DL);
       if (Op0 && Op1) {
         return ConstantFoldCompareInstOperands(CondCmp->getPredicate(), Op0,
                                                Op1, DL);

``````````

</details>


https://github.com/llvm/llvm-project/pull/129501