[llvm] Reland "[Transforms] LoopIdiomRecognize recognize strlen and wcslen (#108985)" (PR #131412)

[Nikita Popov via llvm-commits]

================
@@ -1494,7 +1512,17 @@ bool LoopIdiomRecognize::runOnNoncountableLoop() {
 
   return recognizePopcount() || recognizeAndInsertFFS() ||
          recognizeShiftUntilBitTest() || recognizeShiftUntilZero() ||
-         recognizeShiftUntilLessThan();
+         recognizeShiftUntilLessThan() || recognizeAndInsertStrLen();
+}
+
+/// Check if a Value is either a nullptr or a constant int zero
+static bool isZeroConstant(const Value *Val) {
+  if (isa<ConstantPointerNull>(Val))
+    return true;
+  const ConstantInt *CmpZero = dyn_cast<ConstantInt>(Val);
+  if (!CmpZero || !CmpZero->isZero())
+    return false;
+  return true;
----------------
nikic wrote:

This looks like `match(Val, m_Zero())`. Though I'm not super clear on why this patch has to add the pointer handling at all.

https://github.com/llvm/llvm-project/pull/131412