[llvm] [MC][SystemZ] Introduce Target Specific HLASM Streamer for z/OS (PR #130535)

via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 21 08:23:26 PDT 2025


tltao wrote:

> LGTM, thanks! It would be nice, now that you're adding a `SystemZTargetStreamer.cpp` file, to move the other TargetStreamer methods out of SystemZMCTargetDesc.cpp. The `SystemZTargetStreamer::emitConstantPools` routine should go to the new .cpp file; the `SystemZTargetAsmStreamer` and `SystemZTargetELFStreamer` classes should go to the .h file. (And the former should now probably be renamed to `SystemZTargetGNUAsmStreamer`.)

Good ideas. I will open a new PR to make those changes. In the meantime, should I break this PR down to smaller pieces or is it good to merge as is? 

https://github.com/llvm/llvm-project/pull/130535


More information about the llvm-commits mailing list