[llvm] a013387 - [DebugInfo] Use heterogenous lookups with std::map (NFC) (#132354)

[via llvm-commits]

Author: Kazu Hirata
Date: 2025-03-21T08:03:46-07:00
New Revision: a013387f73cec51c2df4f7732fa87aa01709cc89

URL: https://github.com/llvm/llvm-project/commit/a013387f73cec51c2df4f7732fa87aa01709cc89
DIFF: https://github.com/llvm/llvm-project/commit/a013387f73cec51c2df4f7732fa87aa01709cc89.diff

LOG: [DebugInfo] Use heterogenous lookups with std::map (NFC) (#132354)

Heterogenous lookups allow us to call find with StringRef, avoiding a
temporary heap allocation of std::string.

Added: 
    

Modified: 
    llvm/include/llvm/DebugInfo/DWARF/DWARFVerifier.h
    llvm/lib/DebugInfo/DWARF/DWARFVerifier.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/include/llvm/DebugInfo/DWARF/DWARFVerifier.h b/llvm/include/llvm/DebugInfo/DWARF/DWARFVerifier.h
index f51571aa24c38..595215ba35dd5 100644
--- a/llvm/include/llvm/DebugInfo/DWARF/DWARFVerifier.h
+++ b/llvm/include/llvm/DebugInfo/DWARF/DWARFVerifier.h
@@ -37,7 +37,7 @@ struct AggregationData {
 
 class OutputCategoryAggregator {
 private:
-  std::map<std::string, AggregationData> Aggregation;
+  std::map<std::string, AggregationData, std::less<>> Aggregation;
   bool IncludeDetail;
 
 public:

diff  --git a/llvm/lib/DebugInfo/DWARF/DWARFVerifier.cpp b/llvm/lib/DebugInfo/DWARF/DWARFVerifier.cpp
index 05bb829cf44db..69027500ab51d 100644
--- a/llvm/lib/DebugInfo/DWARF/DWARFVerifier.cpp
+++ b/llvm/lib/DebugInfo/DWARF/DWARFVerifier.cpp
@@ -2194,7 +2194,7 @@ void OutputCategoryAggregator::EnumerateResults(
 }
 void OutputCategoryAggregator::EnumerateDetailedResultsFor(
     StringRef category, std::function<void(StringRef, unsigned)> handleCounts) {
-  const auto Agg = Aggregation.find(std::string(category));
+  const auto Agg = Aggregation.find(category);
   if (Agg != Aggregation.end()) {
     for (const auto &[name, aggData] : Agg->second.DetailedCounts) {
       handleCounts(name, aggData);