[flang] [llvm] [flang][llvm][OpenMP][OpenACC] Add implicit casts to omp.atomic and acc.atomic (PR #131603)

[via llvm-commits]

================
@@ -386,6 +442,7 @@ void genOmpAccAtomicRead(Fortran::lower::AbstractConverter &converter,
       fir::getBase(converter.genExprAddr(fromExpr, stmtCtx));
   mlir::Value toAddress = fir::getBase(converter.genExprAddr(
       *Fortran::semantics::GetExpr(assignmentStmtVariable), stmtCtx));
+  emitImplicitCast(converter, loc, fromAddress, toAddress, elementType);
----------------
NimishMishra wrote:

Thanks @tblah.

I was wondering whether it might make to add a unit attribute to atomic capture, which lets the frontend (like Flang) signal to the verifier if the operation is malformed due to frontend reasons (like implicit casts, as we are exploring here). In that case, if that attribute is set, the verifier simply emits an appropriate message. Would such an approach make sense?

https://github.com/llvm/llvm-project/pull/131603