[llvm] [bindings] Add OCaml binding to `LLVMGlobalSetMetadata` (PR #131583)
Rynco Maekawa via llvm-commits
llvm-commits at lists.llvm.org
Thu Mar 20 19:11:42 PDT 2025
lynzrand wrote:
> Okay, I verified that the failing test doesn't have to do with this PR.
Thanks!
> > BTW, what is the default OCamlFormat parameters for the binding files? I have OCamlFormat installed locally, but it seems like it's formatting using a different config than the current one. I'm currently maintaining format of OCaml files by hand.
>
> I don't believe the bindings use an ocamlformat file. There is some kind of consistent style that you should try to adhere to, but they're not being enforced by any formatting rules.
I was asking this because I saw the two `.ocamlformat` files in the binding and test directories. Doing some `git log` checking, seems like they were added in 506df1bbfd16233134a6ddea96ed2d49077840fd and c244cd72172ca8941f9f67fc183ade8afcd61c17, and remained empty since then. It doesn't seem like any of the OCaml files are using the formatter.
IMHO, although unrelated to this PR, that if we have the `.ocamlformat` files, maybe we should consider using them to enforce a specific formatting of the sources? Or if we aren't using them anyway, we might consider deleting them (in a later PR)?
https://github.com/llvm/llvm-project/pull/131583
More information about the llvm-commits
mailing list