[clang] [llvm] [RISCV] Implement the implications of C extension (PR #132259)
via llvm-commits
llvm-commits at lists.llvm.org
Thu Mar 20 10:43:16 PDT 2025
github-actions[bot] wrote:
<!--LLVM CODE FORMAT COMMENT: {clang-format}-->
:warning: C/C++ code formatter, clang-format found issues in your code. :warning:
<details>
<summary>
You can test this locally with the following command:
</summary>
``````````bash
git-clang-format --diff d0d33d2b5ba3369d4a5586234181055935965e49 e147dd68477b7e5ec9e6363a45fd7568fe595b04 --extensions c,cpp -- clang/test/CodeGen/RISCV/riscv-func-attr-target.c clang/test/CodeGen/attr-target-clones-riscv.c clang/test/CodeGen/attr-target-version-riscv.c clang/test/CodeGenCXX/attr-target-clones-riscv.cpp clang/test/CodeGenCXX/attr-target-version-riscv.cpp llvm/lib/TargetParser/RISCVISAInfo.cpp llvm/unittests/TargetParser/RISCVISAInfoTest.cpp
``````````
</details>
<details>
<summary>
View the diff from clang-format here.
</summary>
``````````diff
diff --git a/llvm/lib/TargetParser/RISCVISAInfo.cpp b/llvm/lib/TargetParser/RISCVISAInfo.cpp
index 292890bf2e..fb0f6943c9 100644
--- a/llvm/lib/TargetParser/RISCVISAInfo.cpp
+++ b/llvm/lib/TargetParser/RISCVISAInfo.cpp
@@ -863,8 +863,7 @@ void RISCVISAInfo::updateImplication() {
}
// Add Zcf if C and F are enabled on RV32.
- if (XLen == 32 && Exts.count("c") && Exts.count("f") &&
- !Exts.count("zcf")) {
+ if (XLen == 32 && Exts.count("c") && Exts.count("f") && !Exts.count("zcf")) {
auto Version = findDefaultVersion("zcf");
Exts["zcf"] = *Version;
}
diff --git a/llvm/unittests/TargetParser/RISCVISAInfoTest.cpp b/llvm/unittests/TargetParser/RISCVISAInfoTest.cpp
index bd117e8aa9..c66e9511ce 100644
--- a/llvm/unittests/TargetParser/RISCVISAInfoTest.cpp
+++ b/llvm/unittests/TargetParser/RISCVISAInfoTest.cpp
@@ -303,8 +303,10 @@ TEST(ParseArchString, AcceptsSupportedBaseISAsAndSetsXLenAndFLen) {
EXPECT_TRUE(ExtsRV64GCV.at("zicsr") == (RISCVISAUtils::ExtensionVersion{2, 0}));
EXPECT_TRUE(ExtsRV64GCV.at("zifencei") ==
(RISCVISAUtils::ExtensionVersion{2, 0}));
- EXPECT_TRUE(ExtsRV64GCV.at("zmmul") == (RISCVISAUtils::ExtensionVersion{1, 0}));
- EXPECT_TRUE(ExtsRV64GCV.at("zaamo") == (RISCVISAUtils::ExtensionVersion{1, 0}));
+ EXPECT_TRUE(ExtsRV64GCV.at("zmmul") ==
+ (RISCVISAUtils::ExtensionVersion{1, 0}));
+ EXPECT_TRUE(ExtsRV64GCV.at("zaamo") ==
+ (RISCVISAUtils::ExtensionVersion{1, 0}));
EXPECT_TRUE(ExtsRV64GCV.at("zalrsc") ==
(RISCVISAUtils::ExtensionVersion{1, 0}));
EXPECT_TRUE(ExtsRV64GCV.at("zca") == (RISCVISAUtils::ExtensionVersion{1, 0}));
``````````
</details>
https://github.com/llvm/llvm-project/pull/132259
More information about the llvm-commits
mailing list