[llvm] [GVN] Add MemorySSA checks in tests 1/N (PR #130261)

Madhur Amilkanthwar via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 20 03:48:42 PDT 2025


https://github.com/madhur13490 updated https://github.com/llvm/llvm-project/pull/130261

>From a9ced58e10276380cf0759c8d7c23dc61bce81db Mon Sep 17 00:00:00 2001
From: Madhur Amilkanthwar <madhura at nvidia.com>
Date: Thu, 6 Mar 2025 21:59:00 -0800
Subject: [PATCH] [GVN] Add MemorySSA checks in tests 1/N

---
 llvm/test/Transforms/GVN/assume.ll      | 26 +++++++++-
 llvm/test/Transforms/GVN/basic.ll       | 22 ++++++---
 llvm/test/Transforms/GVN/nonescaping.ll | 65 ++++++++++++++++++++-----
 llvm/test/Transforms/GVN/pr14166.ll     | 39 ++++++++++++---
 4 files changed, 123 insertions(+), 29 deletions(-)

diff --git a/llvm/test/Transforms/GVN/assume.ll b/llvm/test/Transforms/GVN/assume.ll
index 6cb4c871750d6..d4b1e73ad5e83 100644
--- a/llvm/test/Transforms/GVN/assume.ll
+++ b/llvm/test/Transforms/GVN/assume.ll
@@ -1,5 +1,6 @@
 ; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
-; RUN: opt < %s -passes=gvn -verify-analysis-invalidation -S | FileCheck %s
+; RUN: opt < %s -passes=gvn -verify-analysis-invalidation -S | FileCheck --check-prefix=CHECK,MDEP %s
+; RUN: opt < %s -passes='gvn<memoryssa;no-memdep>' -verify-analysis-invalidation -S | FileCheck --check-prefixes=CHECK,MSSA %s
 
 declare void @llvm.assume(i1)
 declare void @use(i1)
@@ -8,6 +9,8 @@ define void @assume_true() {
 ; CHECK-LABEL: @assume_true(
 ; CHECK-NEXT:    ret void
 ;
+; CHECK-MSSA-LABEL: @assume_true(
+; CHECK-MSSA-NEXT:    ret void
   call void @llvm.assume(i1 true)
   ret void
 }
@@ -17,6 +20,9 @@ define void @assume_false() {
 ; CHECK-NEXT:    store i8 poison, ptr null, align 1
 ; CHECK-NEXT:    ret void
 ;
+; CHECK-MSSA-LABEL: @assume_false(
+; CHECK-MSSA-NEXT:    store i8 poison, ptr null, align 1
+; CHECK-MSSA-NEXT:    ret void
   call void @llvm.assume(i1 false)
   ret void
 }
@@ -27,6 +33,10 @@ define void @assume_arg(i1 %x) {
 ; CHECK-NEXT:    call void @use(i1 true)
 ; CHECK-NEXT:    ret void
 ;
+; CHECK-MSSA-LABEL: @assume_arg(
+; CHECK-MSSA-NEXT:    call void @llvm.assume(i1 [[X:%.*]])
+; CHECK-MSSA-NEXT:    call void @use(i1 true)
+; CHECK-MSSA-NEXT:    ret void
   call void @llvm.assume(i1 %x)
   call void @use(i1 %x)
   ret void
@@ -39,6 +49,11 @@ define void @assume_not_arg(i1 %x) {
 ; CHECK-NEXT:    call void @use(i1 false)
 ; CHECK-NEXT:    ret void
 ;
+; CHECK-MSSA-LABEL: @assume_not_arg(
+; CHECK-MSSA-NEXT:    [[XOR:%.*]] = xor i1 [[X:%.*]], true
+; CHECK-MSSA-NEXT:    call void @llvm.assume(i1 [[XOR]])
+; CHECK-MSSA-NEXT:    call void @use(i1 false)
+; CHECK-MSSA-NEXT:    ret void
   %xor = xor i1 %x, true
   call void @llvm.assume(i1 %xor)
   call void @use(i1 %x)
@@ -53,9 +68,18 @@ define void @pr47496(i8 %x) {
 ; CHECK-NEXT:    call void @use(i1 false)
 ; CHECK-NEXT:    ret void
 ;
+; CHECK-MSSA-LABEL: @pr47496(
+; CHECK-MSSA-NEXT:    [[CMP:%.*]] = icmp slt i8 [[X:%.*]], 0
+; CHECK-MSSA-NEXT:    [[XOR:%.*]] = xor i1 [[CMP]], true
+; CHECK-MSSA-NEXT:    call void @llvm.assume(i1 [[XOR]])
+; CHECK-MSSA-NEXT:    call void @use(i1 false)
+; CHECK-MSSA-NEXT:    ret void
   %cmp = icmp slt i8 %x, 0
   %xor = xor i1 %cmp, true
   call void @llvm.assume(i1 %xor)
   call void @use(i1 %cmp)
   ret void
 }
+;; NOTE: These prefixes are unused and the list is autogenerated. Do not add tests below this line:
+; MDEP: {{.*}}
+; MSSA: {{.*}}
diff --git a/llvm/test/Transforms/GVN/basic.ll b/llvm/test/Transforms/GVN/basic.ll
index 09155bf4cf2fd..f87a2efadebe0 100644
--- a/llvm/test/Transforms/GVN/basic.ll
+++ b/llvm/test/Transforms/GVN/basic.ll
@@ -1,15 +1,23 @@
-; RUN: opt < %s -passes=gvn -S | FileCheck %s
+; NOTE: Assertions have been autogenerated by utils/update_test_checks.py UTC_ARGS: --version 5
+; RUN: opt < %s -passes=gvn -S | FileCheck %s --check-prefixes=CHECK,MDEP
+; RUN: opt < %s -passes='gvn<memoryssa;no-memdep>' -S | FileCheck --check-prefixes=CHECK,MSSA %s
 
 define i32 @main() {
+; CHECK-LABEL: define i32 @main() {
+; CHECK-NEXT:  [[BLOCK1:.*:]]
+; CHECK-NEXT:    ret i32 0
+;
+; CHECK-MSSA-LABEL: define i32 @main() {
+; CHECK-MSSA-NEXT:  [[BLOCK1:.*:]]
+; CHECK-MSSA-NEXT:    ret i32 0
 block1:
-	%z1 = bitcast i32 0 to i32
-	br label %block2
+  %z1 = bitcast i32 0 to i32
+  br label %block2
 block2:
   %z2 = bitcast i32 0 to i32
   ret i32 %z2
 }
 
-; CHECK: define i32 @main() {
-; CHECK-NEXT: block1:
-; CHECK-NEXT:   ret i32 0
-; CHECK-NEXT: }
+;; NOTE: These prefixes are unused and the list is autogenerated. Do not add tests below this line:
+; MDEP: {{.*}}
+; MSSA: {{.*}}
diff --git a/llvm/test/Transforms/GVN/nonescaping.ll b/llvm/test/Transforms/GVN/nonescaping.ll
index ad6fa1db0f93e..c061493ce344a 100644
--- a/llvm/test/Transforms/GVN/nonescaping.ll
+++ b/llvm/test/Transforms/GVN/nonescaping.ll
@@ -1,5 +1,6 @@
 ; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
-; RUN: opt < %s -S -passes=gvn 2>&1 | FileCheck %s
+; RUN: opt < %s -S -passes=gvn 2>&1 | FileCheck %s --check-prefixes=CHECK,MDEP
+; RUN: opt < %s -S -passes='gvn<memoryssa;no-memdep>' 2>&1 | FileCheck --check-prefixes=CHECK,MSSA %s
 
 target datalayout = "e-p:64:64:64-i1:8:8-i8:8:8-i16:16:16-i32:32:32-i64:64:64-f32:32:32-f64:64:64-v64:64:64-v128:128:128-a0:0:64-s0:64:64-f80:128:128"
 
@@ -9,11 +10,23 @@ declare noalias ptr @_Znwm(i64)
 declare void @escape(ptr)
 
 define i8 @test_malloc(ptr %p) {
-; CHECK-LABEL: @test_malloc(
-; CHECK-NEXT:    [[OBJ:%.*]] = call ptr @malloc(i64 16)
-; CHECK-NEXT:    call void @escape(ptr [[OBJ]])
-; CHECK-NEXT:    ret i8 0
+; MDEP-LABEL: @test_malloc(
+; MDEP-NEXT:    [[OBJ:%.*]] = call ptr @malloc(i64 16)
+; MDEP-NEXT:    call void @escape(ptr [[OBJ]])
+; MDEP-NEXT:    ret i8 0
 ;
+; MSSA-LABEL: @test_malloc(
+; MSSA-NEXT:    [[V1:%.*]] = load i8, ptr [[P:%.*]], align 1
+; MSSA-NEXT:    [[OBJ:%.*]] = call ptr @malloc(i64 16)
+; MSSA-NEXT:    [[V2:%.*]] = load i8, ptr [[P]], align 1
+; MSSA-NEXT:    [[SUB:%.*]] = sub i8 [[V1]], [[V2]]
+; MSSA-NEXT:    call void @escape(ptr [[OBJ]])
+; MSSA-NEXT:    ret i8 [[SUB]]
+;
+; CHECK-MSSA-LABEL: @test_malloc(
+; CHECK-MSSA-NEXT:    [[OBJ:%.*]] = call ptr @malloc(i64 16)
+; CHECK-MSSA-NEXT:    call void @escape(ptr [[OBJ]])
+; CHECK-MSSA-NEXT:    ret i8 0
   %v1 = load i8, ptr %p
   %obj = call ptr @malloc(i64 16)
   %v2 = load i8, ptr %p
@@ -23,11 +36,23 @@ define i8 @test_malloc(ptr %p) {
 }
 
 define i8 @test_calloc(ptr %p) {
-; CHECK-LABEL: @test_calloc(
-; CHECK-NEXT:    [[OBJ:%.*]] = call ptr @calloc(i64 1, i64 16)
-; CHECK-NEXT:    call void @escape(ptr [[OBJ]])
-; CHECK-NEXT:    ret i8 0
+; MDEP-LABEL: @test_calloc(
+; MDEP-NEXT:    [[OBJ:%.*]] = call ptr @calloc(i64 1, i64 16)
+; MDEP-NEXT:    call void @escape(ptr [[OBJ]])
+; MDEP-NEXT:    ret i8 0
+;
+; MSSA-LABEL: @test_calloc(
+; MSSA-NEXT:    [[V1:%.*]] = load i8, ptr [[P:%.*]], align 1
+; MSSA-NEXT:    [[OBJ:%.*]] = call ptr @calloc(i64 1, i64 16)
+; MSSA-NEXT:    [[V2:%.*]] = load i8, ptr [[P]], align 1
+; MSSA-NEXT:    [[SUB:%.*]] = sub i8 [[V1]], [[V2]]
+; MSSA-NEXT:    call void @escape(ptr [[OBJ]])
+; MSSA-NEXT:    ret i8 [[SUB]]
 ;
+; CHECK-MSSA-LABEL: @test_calloc(
+; CHECK-MSSA-NEXT:    [[OBJ:%.*]] = call ptr @calloc(i64 1, i64 16)
+; CHECK-MSSA-NEXT:    call void @escape(ptr [[OBJ]])
+; CHECK-MSSA-NEXT:    ret i8 0
   %v1 = load i8, ptr %p
   %obj = call ptr @calloc(i64 1, i64 16)
   %v2 = load i8, ptr %p
@@ -37,11 +62,23 @@ define i8 @test_calloc(ptr %p) {
 }
 
 define i8 @test_opnew(ptr %p) {
-; CHECK-LABEL: @test_opnew(
-; CHECK-NEXT:    [[OBJ:%.*]] = call ptr @_Znwm(i64 16)
-; CHECK-NEXT:    call void @escape(ptr [[OBJ]])
-; CHECK-NEXT:    ret i8 0
+; MDEP-LABEL: @test_opnew(
+; MDEP-NEXT:    [[OBJ:%.*]] = call ptr @_Znwm(i64 16)
+; MDEP-NEXT:    call void @escape(ptr [[OBJ]])
+; MDEP-NEXT:    ret i8 0
+;
+; MSSA-LABEL: @test_opnew(
+; MSSA-NEXT:    [[V1:%.*]] = load i8, ptr [[P:%.*]], align 1
+; MSSA-NEXT:    [[OBJ:%.*]] = call ptr @_Znwm(i64 16)
+; MSSA-NEXT:    [[V2:%.*]] = load i8, ptr [[P]], align 1
+; MSSA-NEXT:    [[SUB:%.*]] = sub i8 [[V1]], [[V2]]
+; MSSA-NEXT:    call void @escape(ptr [[OBJ]])
+; MSSA-NEXT:    ret i8 [[SUB]]
 ;
+; CHECK-MSSA-LABEL: @test_opnew(
+; CHECK-MSSA-NEXT:    [[OBJ:%.*]] = call ptr @_Znwm(i64 16)
+; CHECK-MSSA-NEXT:    call void @escape(ptr [[OBJ]])
+; CHECK-MSSA-NEXT:    ret i8 0
   %v1 = load i8, ptr %p
   %obj = call ptr @_Znwm(i64 16)
   %v2 = load i8, ptr %p
@@ -51,3 +88,5 @@ define i8 @test_opnew(ptr %p) {
 }
 
 
+;; NOTE: These prefixes are unused and the list is autogenerated. Do not add tests below this line:
+; CHECK: {{.*}}
diff --git a/llvm/test/Transforms/GVN/pr14166.ll b/llvm/test/Transforms/GVN/pr14166.ll
index 3379a5f604b0b..ecb6d0c6b574e 100644
--- a/llvm/test/Transforms/GVN/pr14166.ll
+++ b/llvm/test/Transforms/GVN/pr14166.ll
@@ -1,6 +1,34 @@
-; RUN: opt -disable-basic-aa -passes=gvn -S < %s | FileCheck %s
+; NOTE: Assertions have been autogenerated by utils/update_test_checks.py UTC_ARGS: --version 5
+; RUN: opt -disable-basic-aa -passes=gvn -S < %s | FileCheck %s --check-prefixes=CHECK,MDEP
+; RUN: opt -disable-basic-aa -passes='gvn<memoryssa;no-memdep>' -S < %s | FileCheck --check-prefixes=CHECK,MSSA %s
 target datalayout = "e-p:32:32:32"
 define <2 x i32> @test1() {
+; MDEP-LABEL: define <2 x i32> @test1() {
+; MDEP-NEXT:    [[V1:%.*]] = alloca <2 x i32>, align 8
+; MDEP-NEXT:    call void @anything(ptr [[V1]])
+; MDEP-NEXT:    [[V2:%.*]] = load <2 x i32>, ptr [[V1]], align 8
+; MDEP-NEXT:    [[V3:%.*]] = inttoptr <2 x i32> [[V2]] to <2 x ptr>
+; MDEP-NEXT:    store <2 x ptr> [[V3]], ptr [[V1]], align 8
+; MDEP-NEXT:    [[TMP1:%.*]] = bitcast <2 x i32> [[V2]] to i64
+; MDEP-NEXT:    ret <2 x i32> [[V2]]
+;
+; MSSA-LABEL: define <2 x i32> @test1() {
+; MSSA-NEXT:    [[V1:%.*]] = alloca <2 x i32>, align 8
+; MSSA-NEXT:    call void @anything(ptr [[V1]])
+; MSSA-NEXT:    [[V2:%.*]] = load <2 x i32>, ptr [[V1]], align 8
+; MSSA-NEXT:    [[V3:%.*]] = inttoptr <2 x i32> [[V2]] to <2 x ptr>
+; MSSA-NEXT:    store <2 x ptr> [[V3]], ptr [[V1]], align 8
+; MSSA-NEXT:    [[V5:%.*]] = load <2 x i32>, ptr [[V1]], align 8
+; MSSA-NEXT:    ret <2 x i32> [[V5]]
+;
+; CHECK-MSSA-LABEL: define <2 x i32> @test1() {
+; CHECK-MSSA-NEXT:    [[V1:%.*]] = alloca <2 x i32>, align 8
+; CHECK-MSSA-NEXT:    call void @anything(ptr [[V1]])
+; CHECK-MSSA-NEXT:    [[V2:%.*]] = load <2 x i32>, ptr [[V1]], align 8
+; CHECK-MSSA-NEXT:    [[V3:%.*]] = inttoptr <2 x i32> [[V2]] to <2 x ptr>
+; CHECK-MSSA-NEXT:    store <2 x ptr> [[V3]], ptr [[V1]], align 8
+; CHECK-MSSA-NEXT:    [[TMP1:%.*]] = bitcast <2 x i32> [[V2]] to i64
+; CHECK-MSSA-NEXT:    ret <2 x i32> [[V2]]
   %v1 = alloca <2 x i32>
   call void @anything(ptr %v1)
   %v2 = load <2 x i32>, ptr %v1
@@ -8,14 +36,9 @@ define <2 x i32> @test1() {
   store <2 x ptr> %v3, ptr %v1
   %v5 = load <2 x i32>, ptr %v1
   ret <2 x i32> %v5
-; CHECK-LABEL: @test1(
-; CHECK: %v1 = alloca <2 x i32>
-; CHECK: call void @anything(ptr %v1)
-; CHECK: %v2 = load <2 x i32>, ptr %v1
-; CHECK: %v3 = inttoptr <2 x i32> %v2 to <2 x ptr>
-; CHECK: store <2 x ptr> %v3, ptr %v1
-; CHECK: ret <2 x i32> %v2
 }
 
 declare void @anything(ptr)
 
+;; NOTE: These prefixes are unused and the list is autogenerated. Do not add tests below this line:
+; CHECK: {{.*}}



More information about the llvm-commits mailing list