[llvm] [NFC][AMDGPU] Compute always reserved registers once (PR #132006)

Akshat Oke via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 19 04:26:47 PDT 2025


https://github.com/optimisan created https://github.com/llvm/llvm-project/pull/132006

None

>From 2dc8836488ab5832fb273a0d42d7f0ffb97fd2ee Mon Sep 17 00:00:00 2001
From: Akshat Oke <Akshat.Oke at amd.com>
Date: Wed, 19 Mar 2025 11:26:09 +0000
Subject: [PATCH] [NFC][AMDGPU] Compute always reserved registers once

---
 llvm/lib/Target/AMDGPU/SIRegisterInfo.cpp | 18 +++++++++++++++---
 llvm/lib/Target/AMDGPU/SIRegisterInfo.h   |  3 +++
 2 files changed, 18 insertions(+), 3 deletions(-)

diff --git a/llvm/lib/Target/AMDGPU/SIRegisterInfo.cpp b/llvm/lib/Target/AMDGPU/SIRegisterInfo.cpp
index 39df8bb3a9fc8..aa3545849d433 100644
--- a/llvm/lib/Target/AMDGPU/SIRegisterInfo.cpp
+++ b/llvm/lib/Target/AMDGPU/SIRegisterInfo.cpp
@@ -628,12 +628,17 @@ SIRegisterInfo::getMaxNumVectorRegs(const MachineFunction &MF) const {
   return std::pair(MaxNumVGPRs, MaxNumAGPRs);
 }
 
-BitVector SIRegisterInfo::getReservedRegs(const MachineFunction &MF) const {
+BitVector SIRegisterInfo::AlwaysReservedRegs;
+
+BitVector SIRegisterInfo::getAlwaysReservedRegs() const {
+  // Already been calculated, so do not compute again.
+  if (AlwaysReservedRegs.size() == getNumRegs()) {
+    return AlwaysReservedRegs;
+  }
+
   BitVector Reserved(getNumRegs());
   Reserved.set(AMDGPU::MODE);
 
-  const SIMachineFunctionInfo *MFI = MF.getInfo<SIMachineFunctionInfo>();
-
   // Reserve special purpose registers.
   //
   // EXEC_LO and EXEC_HI could be allocated and used as regular register, but
@@ -679,6 +684,12 @@ BitVector SIRegisterInfo::getReservedRegs(const MachineFunction &MF) const {
   // Reserve null register - it shall never be allocated
   reserveRegisterTuples(Reserved, AMDGPU::SGPR_NULL64);
 
+  return this->AlwaysReservedRegs = Reserved;
+}
+
+BitVector SIRegisterInfo::getReservedRegs(const MachineFunction &MF) const {
+  BitVector Reserved = getAlwaysReservedRegs();
+
   // Reserve SGPRs.
   //
   unsigned MaxNumSGPRs = ST.getMaxNumSGPRs(MF);
@@ -694,6 +705,7 @@ BitVector SIRegisterInfo::getReservedRegs(const MachineFunction &MF) const {
     }
   }
 
+  const SIMachineFunctionInfo *MFI = MF.getInfo<SIMachineFunctionInfo>();
   Register ScratchRSrcReg = MFI->getScratchRSrcReg();
   if (ScratchRSrcReg != AMDGPU::NoRegister) {
     // Reserve 4 SGPRs for the scratch buffer resource descriptor in case we
diff --git a/llvm/lib/Target/AMDGPU/SIRegisterInfo.h b/llvm/lib/Target/AMDGPU/SIRegisterInfo.h
index f3068963fd10f..fa50ca2482554 100644
--- a/llvm/lib/Target/AMDGPU/SIRegisterInfo.h
+++ b/llvm/lib/Target/AMDGPU/SIRegisterInfo.h
@@ -55,6 +55,9 @@ class SIRegisterInfo final : public AMDGPUGenRegisterInfo {
   // Second index is 32 different dword offsets.
   static std::array<std::array<uint16_t, 32>, 9> SubRegFromChannelTable;
 
+  static BitVector AlwaysReservedRegs;
+  BitVector getAlwaysReservedRegs() const;
+
   void reserveRegisterTuples(BitVector &, MCRegister Reg) const;
 
 public:



More information about the llvm-commits mailing list