[llvm] [X86][GlobalISel] Support addr matching in SDAG patterns (PR #130445)

Simon Pilgrim via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 18 06:15:43 PDT 2025


================
@@ -291,11 +291,23 @@ define i16 @or_imm8_i16(i16 %a) {
 }
 
 define i32 @or_imm8_i32(i32 %a) {
-; X86-LABEL: or_imm8_i32:
-; X86:       # %bb.0:
-; X86-NEXT:    movl {{[0-9]+}}(%esp), %eax
-; X86-NEXT:    orl $-5, %eax
-; X86-NEXT:    retl
+; SDAG-X86-LABEL: or_imm8_i32:
+; SDAG-X86:       # %bb.0:
+; SDAG-X86-NEXT:    movl {{[0-9]+}}(%esp), %eax
+; SDAG-X86-NEXT:    orl $-5, %eax
+; SDAG-X86-NEXT:    retl
+;
+; FASTISEL-X86-LABEL: or_imm8_i32:
+; FASTISEL-X86:       # %bb.0:
+; FASTISEL-X86-NEXT:    movl {{[0-9]+}}(%esp), %eax
+; FASTISEL-X86-NEXT:    orl $-5, %eax
+; FASTISEL-X86-NEXT:    retl
+;
+; GISEL-X86-LABEL: or_imm8_i32:
+; GISEL-X86:       # %bb.0:
+; GISEL-X86-NEXT:    movl $-5, %eax
+; GISEL-X86-NEXT:    orl {{[0-9]+}}(%esp), %eax
----------------
RKSimon wrote:

Is GISel missing constant to RHS canonicalization or is something else going on?

https://github.com/llvm/llvm-project/pull/130445


More information about the llvm-commits mailing list