https://github.com/inbelic commented: Nice work, just some minor comments/questions. As mentioned, we should have a definitive answer to if we need SRV to be included at all here (both in code comments and testcases). https://github.com/llvm/llvm-project/pull/131070