[llvm] [JSON][NFC] Move print method out of NDEBUG || DUMP (PR #131639)

Nikita Popov via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 17 13:58:00 PDT 2025


nikic wrote:

I believe mixing asserts and non-asserts builds is supported in principle, but you need to take care on the exact configuration (LLVM_ENABLE_DUMP and LLVM_ENABLE_ABI_BREAKING_CHECKS need to be configured appropriately on both sides of the fence).

But TBH, I'd be fine if we just generally (across the whole codebase) stopped making dump definitions conditional. I doubt that these take up enough code size for this to be worthwhile optimization. (We can keep the existing behavior that LLVM_DUMP_METHOD is only defined as LLVM_USED in assertions builds, so it can still be optimized out in LTO builds.)

https://github.com/llvm/llvm-project/pull/131639


More information about the llvm-commits mailing list