[llvm] 4ce1d1f - [ADT] Add DenseSet::insert_range (#131567)

[via llvm-commits]

Author: Kazu Hirata
Date: 2025-03-17T13:19:12-07:00
New Revision: 4ce1d1f1d90d19fb7094f2dcca3b46fef81c1e27

URL: https://github.com/llvm/llvm-project/commit/4ce1d1f1d90d19fb7094f2dcca3b46fef81c1e27
DIFF: https://github.com/llvm/llvm-project/commit/4ce1d1f1d90d19fb7094f2dcca3b46fef81c1e27.diff

LOG: [ADT] Add DenseSet::insert_range (#131567)

This pach adds DenseSet::insert_range, named after
std::map::insert_range from C++23.  The intent is to allow a heavy
operation as the argument like:

  Set.insert_range(Map[Key]);

Without insert_range, we would have to do:

  Set.insert(Map[Key].begin(), Map[Key].end());

or:

  auto &M = Map[Key];
  Set.insert(M.begin(), M.end());

Neither is elegant.

Added: 
    

Modified: 
    llvm/include/llvm/ADT/DenseSet.h
    llvm/unittests/ADT/DenseSetTest.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/include/llvm/ADT/DenseSet.h b/llvm/include/llvm/ADT/DenseSet.h
index a307bd8c9198b..ac766e778df0d 100644
--- a/llvm/include/llvm/ADT/DenseSet.h
+++ b/llvm/include/llvm/ADT/DenseSet.h
@@ -14,6 +14,7 @@
 #ifndef LLVM_ADT_DENSESET_H
 #define LLVM_ADT_DENSESET_H
 
+#include "llvm/ADT/ADL.h"
 #include "llvm/ADT/DenseMap.h"
 #include "llvm/ADT/DenseMapInfo.h"
 #include "llvm/Support/MathExtras.h"
@@ -237,6 +238,10 @@ class DenseSetImpl {
     for (; I != E; ++I)
       insert(*I);
   }
+
+  template <typename Range> void insert_range(Range &&R) {
+    insert(adl_begin(R), adl_end(R));
+  }
 };
 
 /// Equality comparison for DenseSet.

diff  --git a/llvm/unittests/ADT/DenseSetTest.cpp b/llvm/unittests/ADT/DenseSetTest.cpp
index f14542eafc251..8fc2bab44b124 100644
--- a/llvm/unittests/ADT/DenseSetTest.cpp
+++ b/llvm/unittests/ADT/DenseSetTest.cpp
@@ -7,6 +7,7 @@
 //===----------------------------------------------------------------------===//
 
 #include "llvm/ADT/DenseSet.h"
+#include "gmock/gmock.h"
 #include "gtest/gtest.h"
 #include <type_traits>
 
@@ -32,6 +33,13 @@ TEST(DenseSetTest, DoubleEntrySetTest) {
   EXPECT_EQ(0u, set.count(2));
 }
 
+TEST(DenseSetTest, InsertRange) {
+  llvm::DenseSet<unsigned> set;
+  constexpr unsigned Args[] = {3, 1, 2};
+  set.insert_range(Args);
+  EXPECT_THAT(set, ::testing::UnorderedElementsAre(1, 2, 3));
+}
+
 struct TestDenseSetInfo {
   static inline unsigned getEmptyKey() { return ~0; }
   static inline unsigned getTombstoneKey() { return ~0U - 1; }