[llvm] [JSON][NFC] Move print method out of NDEBUG || DUMP (PR #131639)
Nikolay Panchenko via llvm-commits
llvm-commits at lists.llvm.org
Mon Mar 17 12:48:22 PDT 2025
npanchen wrote:
> Right, I was wrongly looking under a different, restricted, scope. In the file you mentioned, the usage is however limited to the `dump` method, and not to the `print` method as per the previous PR. As I was anticipating, it's fine by me as long as it does not impose any build type assumption to downstream users (and this PR fixes such a problem), but let's also hear others people opinion on this.
Well, I don't think naming matters here. What matters is that `void dump(raw_ostream &OS) const;` is defined in cpp file, i.e. including `MCAsmMacro.h` in debug build and linking with a release LLVM would be the same problem, right ?
https://github.com/llvm/llvm-project/pull/131639
More information about the llvm-commits
mailing list