[llvm] [AMDGPU] ] Correctly merge noalias scopes during lowering of LDS data. (PR #131664)

[via llvm-commits]

github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff bbaf743c461e5e38a72f12f2b6ee6b91674a2a4d 073c1356e0d17a53eaf4afe8006c069d69f24b08 --extensions cpp,h -- llvm/include/llvm/Analysis/ScopedNoAliasAA.h llvm/lib/Analysis/ScopedNoAliasAA.cpp llvm/lib/Target/AMDGPU/AMDGPULowerModuleLDSPass.cpp
``````````

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/llvm/include/llvm/Analysis/ScopedNoAliasAA.h b/llvm/include/llvm/Analysis/ScopedNoAliasAA.h
index 4f658028d5..46c88fe1d5 100644
--- a/llvm/include/llvm/Analysis/ScopedNoAliasAA.h
+++ b/llvm/include/llvm/Analysis/ScopedNoAliasAA.h
@@ -43,9 +43,11 @@ public:
   ModRefInfo getModRefInfo(const CallBase *Call1, const CallBase *Call2,
                            AAQueryInfo &AAQI);
 
-  //SmallPtrSet <const MDNode *, 16> getScopedDomains(const MDNode *NoAlias) const;
+  // SmallPtrSet <const MDNode *, 16> getScopedDomains(const MDNode *NoAlias)
+  // const;
   void collectScopedDomains(const MDNode *NoAlias,
-                            SmallPtrSetImpl<const MDNode*> &Domains) const;
+                            SmallPtrSetImpl<const MDNode *> &Domains) const;
+
 private:
   bool mayAliasInScopes(const MDNode *Scopes, const MDNode *NoAlias) const;
 };
diff --git a/llvm/lib/Analysis/ScopedNoAliasAA.cpp b/llvm/lib/Analysis/ScopedNoAliasAA.cpp
index 4792837206..1c1fbe51a6 100644
--- a/llvm/lib/Analysis/ScopedNoAliasAA.cpp
+++ b/llvm/lib/Analysis/ScopedNoAliasAA.cpp
@@ -115,8 +115,8 @@ static void collectMDInDomain(const MDNode *List, const MDNode *Domain,
 }
 
 // Collect the set of scope domains relevant to the noalias scopes.
-void ScopedNoAliasAAResult::collectScopedDomains(const MDNode *NoAlias,
-                            SmallPtrSetImpl<const MDNode*> &Domains) const {
+void ScopedNoAliasAAResult::collectScopedDomains(
+    const MDNode *NoAlias, SmallPtrSetImpl<const MDNode *> &Domains) const {
   if (!NoAlias)
     return;
   assert(Domains.empty() && "Domains should be empty");
diff --git a/llvm/lib/Target/AMDGPU/AMDGPULowerModuleLDSPass.cpp b/llvm/lib/Target/AMDGPU/AMDGPULowerModuleLDSPass.cpp
index 4ec1c3f20e..31e4d16457 100644
--- a/llvm/lib/Target/AMDGPU/AMDGPULowerModuleLDSPass.cpp
+++ b/llvm/lib/Target/AMDGPU/AMDGPULowerModuleLDSPass.cpp
@@ -185,8 +185,8 @@
 #include "llvm/ADT/DenseSet.h"
 #include "llvm/ADT/STLExtras.h"
 #include "llvm/ADT/SetOperations.h"
-#include "llvm/Analysis/ScopedNoAliasAA.h"
 #include "llvm/Analysis/CallGraph.h"
+#include "llvm/Analysis/ScopedNoAliasAA.h"
 #include "llvm/CodeGen/TargetPassConfig.h"
 #include "llvm/IR/Constants.h"
 #include "llvm/IR/DerivedTypes.h"
@@ -1448,7 +1448,8 @@ private:
       if (auto *I = dyn_cast<Instruction>(U)) {
         if (AliasScope && I->mayReadOrWriteMemory()) {
           MDNode *AS = I->getMetadata(LLVMContext::MD_alias_scope);
-          AS = (AS ? MDNode::getMostGenericAliasScope(AS, AliasScope) : AliasScope);
+          AS = (AS ? MDNode::getMostGenericAliasScope(AS, AliasScope)
+                   : AliasScope);
           I->setMetadata(LLVMContext::MD_alias_scope, AS);
 
           MDNode *NA = I->getMetadata(LLVMContext::MD_noalias);

``````````

</details>


https://github.com/llvm/llvm-project/pull/131664