[llvm] [JSON][NFC] Move print method out of NDEBUG || DUMP (PR #131639)
Michele Scuttari via llvm-commits
llvm-commits at lists.llvm.org
Mon Mar 17 10:49:13 PDT 2025
mscuttari wrote:
> Simple grep of `LLVM_ENABLE_DUMP` shows about 55 cases in `llvm/include`. Some of them might not relate to `dump` or `print` methods. The similar one can be is in [`MCAsmMacro`](https://github.com/llvm/llvm-project/blob/main/llvm/include/llvm/MC/MCAsmMacro.h#L127-L130). I'm fine to drop the use of the macro if that functionality seems nice-to-have for release build, otherwise it's better to keep it under if.
Right, I was wrongly looking under a different, restricted, scope.
In the file you mentioned, the usage is however limited to the `dump` method, and not to the `print` method as per the previous PR.
As I was anticipating, it's fine by me as long as it does not impose any build type assumption to downstream users (and this PR fixes such a problem), but let's also hear others people opinion on this.
https://github.com/llvm/llvm-project/pull/131639
More information about the llvm-commits
mailing list