[llvm] [JSON][NFC] Move print method out of NDEBUG || DUMP (PR #131639)

Michele Scuttari via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 17 10:21:53 PDT 2025


mscuttari wrote:

The patch fixes the linking problem I was mentioning in the previous pull request (Release-build of LLVM + Debug-build of out-of-tree project), so it looks good from me.

I am still not convinced about having this kind of conditional compilation inside a header file (if you do a global search, you will find such an ifdef only in implementation files). However I will let others discuss on this topic, as it may be fine as long as everything works.

@dwblaikie @kuhar adding you as reviewers, as you are listed as maintainers for the Support library.


https://github.com/llvm/llvm-project/pull/131639


More information about the llvm-commits mailing list