[llvm] [AMDGPU][True16][CodeGen] enable true16 for more codegen test patch 1 (PR #131206)

Mon Mar 17 01:29:01 PDT 2025

mikaelholmen wrote:

Hi @broxigarchen
With this patch
```CodeGen/AMDGPU/fneg-combines.f16.ll```
fails if you've compiled llc with EXPENSIVE_CHECKS.
Then it fails like
```
# After Instruction Selection
# Machine code for function fneg_fadd_0_f16: IsSSA, TracksLiveness
Function Live Ins: $sgpr0 in %0, $sgpr1 in %1

bb.0..entry:
  liveins: $sgpr0, $sgpr1
  %1:sgpr_32 = COPY $sgpr1
  %0:sgpr_32 = COPY $sgpr0
  %2:vgpr_16 = nofpexcept V_RCP_F16_t16_e64 0, %1:sgpr_32, 0, 0, 0, implicit $mode, implicit $exec
  %3:vgpr_32 = V_MOV_B32_e32 0, implicit $exec
  %5:vgpr_16 = COPY %3:vgpr_32
  %4:vgpr_16 = nofpexcept V_MUL_F16_t16_e64 0, killed %2:vgpr_16, 0, %5:vgpr_16, 0, 0, 0, implicit $mode, implicit $exec
  %7:vgpr_16 = COPY %3:vgpr_32
  %6:vgpr_16 = nofpexcept V_ADD_F16_t16_e64 0, killed %4:vgpr_16, 0, %7:vgpr_16, 0, 0, 0, implicit $mode, implicit $exec
  %8:sreg_32_xm0_xexec = nofpexcept V_CMP_NLT_F16_t16_e64 0, %6:vgpr_16, 0, %0:sgpr_32, 0, 0, implicit $mode, implicit $exec
  %9:sreg_32 = S_MOV_B32 32768
  %20:vgpr_32 = COPY %6:vgpr_16
  %21:vgpr_32 = V_XOR_B32_e64 %20:vgpr_32, killed %9:sreg_32, implicit $exec
  %13:sgpr_lo16 = COPY %0:sgpr_32
  %12:vgpr_16 = V_CNDMASK_B16_t16_e64 0, killed %21:vgpr_32, 0, %13:sgpr_lo16, killed %8:sreg_32_xm0_xexec, 0, implicit $exec
  %15:vgpr_16 = COPY %3:vgpr_32
  %14:sreg_32_xm0_xexec = nofpexcept V_CMP_NGT_F16_t16_e64 0, killed %12:vgpr_16, 0, %15:vgpr_16, 0, 0, implicit $mode, implicit $exec
  %16:vgpr_32 = V_MOV_B32_e32 32256, implicit $exec
  %18:vgpr_16 = COPY %16:vgpr_32
  %19:vgpr_16 = COPY %3:vgpr_32
  %17:vgpr_16 = V_CNDMASK_B16_t16_e64 0, killed %18:vgpr_16, 0, %19:vgpr_16, killed %14:sreg_32_xm0_xexec, 0, implicit $exec
  $vgpr0 = COPY %17:vgpr_16
  SI_RETURN_TO_EPILOG $vgpr0

# End machine code for function fneg_fadd_0_f16.

*** Bad machine code: Illegal virtual register for instruction ***
- function:    fneg_fadd_0_f16
- basic block: %bb.0 .entry (0x562e994ac130)
- instruction: %12:vgpr_16 = V_CNDMASK_B16_t16_e64 0, killed %21:vgpr_32, 0, %13:sgpr_lo16, killed %8:sreg_32_xm0_xexec, 0, implicit $exec
- operand 2:   killed %21:vgpr_32
Expected a VS_16 register, but got a VGPR_32 register

*** Bad machine code: Illegal virtual register for instruction ***
- function:    fneg_fadd_0_f16
- basic block: %bb.0 .entry (0x562e994ac130)
- instruction: %12:vgpr_16 = V_CNDMASK_B16_t16_e64 0, killed %21:vgpr_32, 0, %13:sgpr_lo16, killed %8:sreg_32_xm0_xexec, 0, implicit $exec
- operand 4:   %13:sgpr_lo16
Expected a VS_16 register, but got a SGPR_LO16 register
LLVM ERROR: Found 2 machine code errors.
PLEASE submit a bug report to https://github.com/llvm/llvm-project/issues/ and include the crash backtrace.
Stack dump:
0.	Program arguments: /repo/uabelho/main-github/llvm/build-all-expensive/bin/llc -mtriple=amdgcn -mcpu=gfx1100 -mattr=+real-true16
1.	Running pass 'CallGraph Pass Manager' on module '<stdin>'.
2.	Running pass 'Verify generated machine code' on function '@fneg_fadd_0_f16'
 #0 0x0000562e95d9efd6 llvm::sys::PrintStackTrace(llvm::raw_ostream&, int) (/repo/uabelho/main-github/llvm/build-all-expensive/bin/llc+0x7e70fd6)
 #1 0x0000562e95d9ca3e llvm::sys::RunSignalHandlers() (/repo/uabelho/main-github/llvm/build-all-expensive/bin/llc+0x7e6ea3e)
 #2 0x0000562e95d9f699 SignalHandler(int, siginfo_t*, void*) Signals.cpp:0:0
 #3 0x00007f77a641bd10 __restore_rt (/lib64/libpthread.so.0+0x12d10)
 #4 0x00007f77a3dbb52f raise (/lib64/libc.so.6+0x4e52f)
 #5 0x00007f77a3d8ee65 abort (/lib64/libc.so.6+0x21e65)
 #6 0x0000562e95ce0713 llvm::report_fatal_error(llvm::Twine const&, bool) (/repo/uabelho/main-github/llvm/build-all-expensive/bin/llc+0x7db2713)
 #7 0x0000562e94d95450 llvm::initializeMachineVerifierLegacyPassPass(llvm::PassRegistry&) (/repo/uabelho/main-github/llvm/build-all-expensive/bin/llc+0x6e67450)
 #8 0x0000562e94d96472 (anonymous namespace)::MachineVerifierLegacyPass::runOnMachineFunction(llvm::MachineFunction&) MachineVerifier.cpp:0:0
 #9 0x0000562e94c40657 llvm::MachineFunctionPass::runOnFunction(llvm::Function&) (/repo/uabelho/main-github/llvm/build-all-expensive/bin/llc+0x6d12657)
#10 0x0000562e9524101e llvm::FPPassManager::runOnFunction(llvm::Function&) (/repo/uabelho/main-github/llvm/build-all-expensive/bin/llc+0x731301e)
#11 0x0000562e9464776a (anonymous namespace)::CGPassManager::runOnModule(llvm::Module&) CallGraphSCCPass.cpp:0:0
#12 0x0000562e95241b46 llvm::legacy::PassManagerImpl::run(llvm::Module&) (/repo/uabelho/main-github/llvm/build-all-expensive/bin/llc+0x7313b46)
#13 0x0000562e92a02587 compileModule(char**, llvm::LLVMContext&) llc.cpp:0:0
#14 0x0000562e929ffb20 main (/repo/uabelho/main-github/llvm/build-all-expensive/bin/llc+0x4ad1b20)
#15 0x00007f77a3da77e5 __libc_start_main (/lib64/libc.so.6+0x3a7e5)
#16 0x0000562e929fef6e _start (/repo/uabelho/main-github/llvm/build-all-expensive/bin/llc+0x4ad0f6e)
/repo/uabelho/main-github/llvm/test/CodeGen/AMDGPU/fneg-combines.f16.ll:560:28: error: GFX11-SAFE-TRUE16-LABEL: expected string not found in input
; GFX11-SAFE-TRUE16-LABEL: v_fneg_add_multi_use_fneg_x_f16:
                           ^
<stdin>:263:33: note: scanning from here
v_fneg_add_store_use_fneg_x_f16: ; @v_fneg_add_store_use_fneg_x_f16
                                ^
<stdin>:263:37: note: possible intended match here
v_fneg_add_store_use_fneg_x_f16: ; @v_fneg_add_store_use_fneg_x_f16
                                    ^

Input file: <stdin>
Check file: /repo/uabelho/main-github/llvm/test/CodeGen/AMDGPU/fneg-combines.f16.ll

-dump-input=help explains the following input dump.

Input was:
<<<<<<
             .
             .
             .
           258:  .long 0 
           259:  .text 
           260:  .globl v_fneg_add_store_use_fneg_x_f16 ; -- Begin function v_fneg_add_store_use_fneg_x_f16 
           261:  .p2align 2 
           262:  .type v_fneg_add_store_use_fneg_x_f16, at function 
           263: v_fneg_add_store_use_fneg_x_f16: ; @v_fneg_add_store_use_fneg_x_f16 
label:560'0                                     X~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ error: no match found
label:560'1                                         ?                                possible intended match
           264: ; %bb.0: 
label:560'0     ~~~~~~~~~
           265:  s_waitcnt vmcnt(0) expcnt(0) lgkmcnt(0) 
label:560'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
           266:  v_mov_b16_e32 v0.h, v0.l 
label:560'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~
           267:  s_delay_alu instid0(VALU_DEP_1) | instskip(SKIP_1) | instid1(VALU_DEP_2) 
label:560'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
           268:  v_sub_f16_e32 v0.l, v1.l, v0.h 
label:560'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
             .
             .
             .
>>>>>>

--

********************
********************
Failed Tests (1):
  LLVM :: CodeGen/AMDGPU/fneg-combines.f16.ll
```
It also fails with a normal build if you just add "-verify-machineinstrs" like
```llc -mtriple=amdgcn -mcpu=gfx1100 -mattr=+real-true16 < /repo/uabelho/main-github/llvm/test/CodeGen/AMDGPU/fneg-combines.f16.ll -verify-machineinstrs```

https://github.com/llvm/llvm-project/pull/131206