[llvm] [BPF] Fix BitCast Assertion with NonZero AddrSpace (PR #130722)

[via llvm-commits]

yonghong-song wrote:

> I have a nit about the test: for IR to IR passes it is a general practice to run `opt -passes=<the-pass>` and verify the output. But all our tests for CORE seem to follow a different pattern, there is even no way to request `BPFAbstractMemberAccess` from `opt`, a change in the `BPFPassRegistry.def` is needed for that. So this is a moot point.

Yes, I was actually aware of this when I tried to write the test. As you mentioned, we do not add a function pass for that. The main reason is that this test is to test compilation failure, so I didn't add func test.

Yes, previously we mostly care the final result, at least for people who understands final asm code but they may not be really familiar with IR.

https://github.com/llvm/llvm-project/pull/130722