[llvm] [BPF] Fix BitCast Assertion with NonZero AddrSpace (PR #130722)

via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 11 10:54:55 PDT 2025


https://github.com/eddyz87 approved this pull request.

The change looks good to me. At cursory glance I don't see other points in this pass that might require similar change.

I have a nit about the test: for IR to IR passes it is a general practice to run `opt -passes=<the-pass>` and verify the output. But all our tests for CORE seem to follow a different pattern, there is even no way to request `BPFAbstractMemberAccess` from `opt`, a change in the `BPFPassRegistry.def` is needed for that. So this is a moot point.

https://github.com/llvm/llvm-project/pull/130722


More information about the llvm-commits mailing list