[llvm] [WindowsDriver] Always consider `WinSdkVersion` (PR #130377)
    Saleem Abdulrasool via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Mon Mar 10 15:58:35 PDT 2025
    
    
  
================
@@ -475,6 +482,12 @@ bool getUniversalCRTSdkDir(vfs::FileSystem &VFS,
           Path, nullptr))
     return false;
 
+  if (WinSdkVersion) {
----------------
compnerd wrote:
The registry currently takes precedence here - should this not come before that? The only issue then remains is what if they specify `/winsdkdir` and `/winsdkversion`? I think that we should prefer to use the version requested against that SDK directory (or the default path if one is not specified).
https://github.com/llvm/llvm-project/pull/130377
    
    
More information about the llvm-commits
mailing list