[llvm] [WindowsDriver] Always consider `WinSdkVersion` (PR #130377)

Saleem Abdulrasool via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 10 15:58:34 PDT 2025


================
@@ -444,6 +444,13 @@ bool getWindowsSDKDir(vfs::FileSystem &VFS, std::optional<StringRef> WinSdkDir,
     return !WindowsSDKLibVersion.empty();
   }
   if (Major == 10) {
+    if (WinSdkVersion) {
+      // Use the user-provided version as-is.
+      WindowsSDKIncludeVersion = WinSdkVersion->str();
+      WindowsSDKLibVersion = WindowsSDKIncludeVersion;
+      return true;
+    }
----------------
compnerd wrote:

Why limit this to 10? What if someone wants to use an older SDK? It seems that we should be able to entirely avoid the registry lookup right?

https://github.com/llvm/llvm-project/pull/130377


More information about the llvm-commits mailing list