[llvm] [Diagnostics] Return rvalue reference from temporary argument (PR #127400)

[David Blaikie via llvm-commits]

================
@@ -69,6 +69,11 @@ class OptimizationRemarkEmitter {
   /// Output the remark via the diagnostic handler and to the
   /// optimization record file.
   void emit(DiagnosticInfoOptimizationBase &OptDiag);
+  /// Also allow r-value for OptDiag to allow emitting a temporarily-constructed
+  /// diagnostic.
+  void emit(DiagnosticInfoOptimizationBase &&OptDiag) {
+    emit(static_cast<DiagnosticInfoOptimizationBase &>(OptDiag));
----------------
dwblaikie wrote:

Is the cast needed here? (eg: https://godbolt.org/z/rT8xnzfn3 )

https://github.com/llvm/llvm-project/pull/127400