https://github.com/dwblaikie approved this pull request. Looks like OK changes. I wouldn't mind a unit test for something low level/broadly used like this, but wouldn't insist on it. https://github.com/llvm/llvm-project/pull/127400