[llvm] [AArch64][ELF Parser] Fix out-of-scope variable usage (PR #130594)

[via llvm-commits]

https://github.com/sivan-shani created https://github.com/llvm/llvm-project/pull/130594

Return a reference to a persistent variable instead of a temporary copy.

>From 0c7a1249cf799acd639d2cfd2e904891907a10aa Mon Sep 17 00:00:00 2001
From: Sivan Shani <sivan.shani at arm.com>
Date: Mon, 10 Mar 2025 12:53:47 +0000
Subject: [PATCH] [AArch64][ELF Parser] Fix out-of-scope variable usage

Return a reference to a persistent variable instead of a temporary copy.
---
 llvm/lib/Support/ELFAttrParserExtended.cpp | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/llvm/lib/Support/ELFAttrParserExtended.cpp b/llvm/lib/Support/ELFAttrParserExtended.cpp
index f8a6f46360dec..c08ed5e6fe86e 100644
--- a/llvm/lib/Support/ELFAttrParserExtended.cpp
+++ b/llvm/lib/Support/ELFAttrParserExtended.cpp
@@ -53,9 +53,9 @@ ELFExtendedAttrParser::getAttributeString(unsigned Tag) const {
 std::optional<StringRef>
 ELFExtendedAttrParser::getAttributeString(StringRef BuildAttrSubsectionName,
                                           unsigned Tag) const {
-  for (auto SubSection : SubSectionVec) {
+  for (const auto &SubSection : SubSectionVec) {
     if (BuildAttrSubsectionName == SubSection.Name)
-      for (auto BAItem : SubSection.Content) {
+      for (const auto &BAItem : SubSection.Content) {
         if (Tag == BAItem.Tag)
           return std::optional<StringRef>(BAItem.StringValue);
       }