[llvm] [X86] Use Register in X86InstrBuilder.h. NFC (PR #130514)
Phoebe Wang via llvm-commits
llvm-commits at lists.llvm.org
Sun Mar 9 20:40:15 PDT 2025
================
@@ -121,54 +114,58 @@ static inline X86AddressMode getAddressFromInstr(const MachineInstr *MI,
/// with no scale, index or displacement. An example is: DWORD PTR [EAX].
///
static inline const MachineInstrBuilder &
-addDirectMem(const MachineInstrBuilder &MIB, unsigned Reg) {
+addDirectMem(const MachineInstrBuilder &MIB, Register Reg) {
// Because memory references are always represented with five
// values, this adds: Reg, 1, NoReg, 0, NoReg to the instruction.
- return MIB.addReg(Reg).addImm(1).addReg(0).addImm(0).addReg(0);
+ return MIB.addReg(Reg)
+ .addImm(1)
+ .addReg(Register())
+ .addImm(0)
+ .addReg(Register());
}
/// Replace the address used in the instruction with the direct memory
/// reference.
static inline void setDirectAddressInInstr(MachineInstr *MI, unsigned Operand,
- unsigned Reg) {
+ Register Reg) {
// Direct memory address is in a form of: Reg/FI, 1 (Scale), NoReg, 0, NoReg.
MI->getOperand(Operand).ChangeToRegister(Reg, /*isDef=*/false);
MI->getOperand(Operand + 1).setImm(1);
- MI->getOperand(Operand + 2).setReg(0);
+ MI->getOperand(Operand + 2).setReg(Register());
----------------
phoebewang wrote:
I think it makes readability a little worse. Can we keep it `0` or `X86::NoRegister`?
https://github.com/llvm/llvm-project/pull/130514
More information about the llvm-commits
mailing list