[llvm] [WindowsDriver] Always consider `WinSdkVersion` (PR #130377)

[via llvm-commits]

llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-platform-windows

Author: Fabrice de Gans (Steelskin)

<details>
<summary>Changes</summary>

Currently, the `-Xmicrosoft-windows-sdk-version` is only used if `-Xmicrosoft-windows-sdk-root` is also provided. This is a surprising behavior since the argument should still be taking effect if LLVM uses the Windows SDK root from the registry.

Tested locally in a simple Hello World program including `Windows.h` and compiled with `-Xmicrosoft-windows-sdk-version 10.0.18362.0` on a system where the SDK 10.0.22621.0 is also installed and verified that the correct header was included.

---
Full diff: https://github.com/llvm/llvm-project/pull/130377.diff


1 Files Affected:

- (modified) llvm/lib/WindowsDriver/MSVCPaths.cpp (+19-6) 


``````````diff
diff --git a/llvm/lib/WindowsDriver/MSVCPaths.cpp b/llvm/lib/WindowsDriver/MSVCPaths.cpp
index a7bffbb20eba1..60fc096059c62 100644
--- a/llvm/lib/WindowsDriver/MSVCPaths.cpp
+++ b/llvm/lib/WindowsDriver/MSVCPaths.cpp
@@ -85,11 +85,22 @@ getHighestNumericTupleInDirectory(llvm::vfs::FileSystem &VFS,
   return Highest;
 }
 
-static bool getWindows10SDKVersionFromPath(llvm::vfs::FileSystem &VFS,
-                                           const std::string &SDKPath,
-                                           std::string &SDKVersion) {
+static bool getWindows10SDKVersionFromPath(
+    llvm::vfs::FileSystem &VFS, const std::string &SDKPath,
+    std::optional<llvm::StringRef> WinSdkVersion, std::string &SDKVersion) {
   llvm::SmallString<128> IncludePath(SDKPath);
   llvm::sys::path::append(IncludePath, "Include");
+
+  if (WinSdkVersion) {
+    // Use the provided version, if it exists.
+    llvm::SmallString<128> VersionIncludePath(IncludePath);
+    llvm::sys::path::append(VersionIncludePath, *WinSdkVersion);
+    if (VFS.exists(VersionIncludePath)) {
+      SDKVersion = *WinSdkVersion;
+      return true;
+    }
+  }
+
   SDKVersion = getHighestNumericTupleInDirectory(VFS, IncludePath);
   return !SDKVersion.empty();
 }
@@ -122,7 +133,8 @@ static bool getWindowsSDKDirViaCommandLine(
     if (!SDKVersion.empty()) {
       Major = SDKVersion.getMajor();
       Version = SDKVersion.getAsString();
-    } else if (getWindows10SDKVersionFromPath(VFS, Path, Version)) {
+    } else if (getWindows10SDKVersionFromPath(VFS, Path, WinSdkVersion,
+                                              Version)) {
       Major = 10;
     }
     return true;
@@ -444,7 +456,8 @@ bool getWindowsSDKDir(vfs::FileSystem &VFS, std::optional<StringRef> WinSdkDir,
     return !WindowsSDKLibVersion.empty();
   }
   if (Major == 10) {
-    if (!getWindows10SDKVersionFromPath(VFS, Path, WindowsSDKIncludeVersion))
+    if (!getWindows10SDKVersionFromPath(VFS, Path, WinSdkVersion,
+                                        WindowsSDKIncludeVersion))
       return false;
     WindowsSDKLibVersion = WindowsSDKIncludeVersion;
     return true;
@@ -475,7 +488,7 @@ bool getUniversalCRTSdkDir(vfs::FileSystem &VFS,
           Path, nullptr))
     return false;
 
-  return getWindows10SDKVersionFromPath(VFS, Path, UCRTVersion);
+  return getWindows10SDKVersionFromPath(VFS, Path, WinSdkVersion, UCRTVersion);
 }
 
 bool findVCToolChainViaCommandLine(vfs::FileSystem &VFS,

``````````

</details>


https://github.com/llvm/llvm-project/pull/130377