[llvm] e4a6e2e - [NFC][IR] Remove redundant .empty() check (#130352)

[via llvm-commits]

Author: Vitaly Buka
Date: 2025-03-07T14:48:00-08:00
New Revision: e4a6e2eb7176e677eb9a9c45913a284d374d60c5

URL: https://github.com/llvm/llvm-project/commit/e4a6e2eb7176e677eb9a9c45913a284d374d60c5
DIFF: https://github.com/llvm/llvm-project/commit/e4a6e2eb7176e677eb9a9c45913a284d374d60c5.diff

LOG: [NFC][IR] Remove redundant .empty() check (#130352)

Preparation for CFI Index refactoring,
which will fix O(N^2) in ThinLTO indexing.

Added: 
    

Modified: 
    llvm/lib/Bitcode/Writer/BitcodeWriter.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Bitcode/Writer/BitcodeWriter.cpp b/llvm/lib/Bitcode/Writer/BitcodeWriter.cpp
index a3556af9a683c..bddc2cd2180b1 100644
--- a/llvm/lib/Bitcode/Writer/BitcodeWriter.cpp
+++ b/llvm/lib/Bitcode/Writer/BitcodeWriter.cpp
@@ -5064,33 +5064,29 @@ void IndexBitcodeWriter::writeCombinedGlobalValueSummary() {
       getReferencedTypeIds(FS, ReferencedTypeIds);
   }
 
-  if (!Index.cfiFunctionDefs().empty()) {
-    for (auto &S : Index.cfiFunctionDefs()) {
-      if (DefOrUseGUIDs.contains(
-              GlobalValue::getGUID(GlobalValue::dropLLVMManglingEscape(S)))) {
-        NameVals.push_back(StrtabBuilder.add(S));
-        NameVals.push_back(S.size());
-      }
-    }
-    if (!NameVals.empty()) {
-      Stream.EmitRecord(bitc::FS_CFI_FUNCTION_DEFS, NameVals);
-      NameVals.clear();
+  for (auto &S : Index.cfiFunctionDefs()) {
+    if (DefOrUseGUIDs.contains(
+            GlobalValue::getGUID(GlobalValue::dropLLVMManglingEscape(S)))) {
+      NameVals.push_back(StrtabBuilder.add(S));
+      NameVals.push_back(S.size());
     }
   }
+  if (!NameVals.empty()) {
+    Stream.EmitRecord(bitc::FS_CFI_FUNCTION_DEFS, NameVals);
+    NameVals.clear();
+  }
 
-  if (!Index.cfiFunctionDecls().empty()) {
-    for (auto &S : Index.cfiFunctionDecls()) {
-      if (DefOrUseGUIDs.contains(
-              GlobalValue::getGUID(GlobalValue::dropLLVMManglingEscape(S)))) {
-        NameVals.push_back(StrtabBuilder.add(S));
-        NameVals.push_back(S.size());
-      }
-    }
-    if (!NameVals.empty()) {
-      Stream.EmitRecord(bitc::FS_CFI_FUNCTION_DECLS, NameVals);
-      NameVals.clear();
+  for (auto &S : Index.cfiFunctionDecls()) {
+    if (DefOrUseGUIDs.contains(
+            GlobalValue::getGUID(GlobalValue::dropLLVMManglingEscape(S)))) {
+      NameVals.push_back(StrtabBuilder.add(S));
+      NameVals.push_back(S.size());
     }
   }
+  if (!NameVals.empty()) {
+    Stream.EmitRecord(bitc::FS_CFI_FUNCTION_DECLS, NameVals);
+    NameVals.clear();
+  }
 
   // Walk the GUIDs that were referenced, and write the
   // corresponding type id records.