[llvm] [EquivClasses] Introduce members iterator-helper (PR #130139)

Fri Mar 7 09:34:04 PST 2025

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `openmp-offload-amdgpu-runtime-2` running on `rocm-worker-hw-02` while building `llvm` at step 8 "Add check check-llvm".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/10/builds/837

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 8 (Add check check-llvm) failure: test (failure)
...
[632/696] Linking CXX executable unittests/Target/TargetMachineCTests
[633/696] Linking CXX executable unittests/Transforms/IPO/IPOTests
[634/696] Linking CXX executable unittests/tools/llvm-profgen/LLVMProfgenTests
[635/696] Linking CXX executable unittests/tools/llvm-profdata/LLVMProfdataTests
[636/696] Linking CXX executable unittests/tools/llvm-cfi-verify/CFIVerifyTests
[637/696] Linking CXX executable unittests/XRay/XRayTests
[638/696] Linking CXX executable unittests/tools/llvm-mca/LLVMMCATests
[639/696] Linking CXX executable unittests/tools/llvm-exegesis/LLVMExegesisTests
[640/696] Linking CXX executable unittests/Support/SupportTests
[641/696] Building CXX object unittests/ADT/CMakeFiles/ADTTests.dir/EquivalenceClassesTest.cpp.o
FAILED: unittests/ADT/CMakeFiles/ADTTests.dir/EquivalenceClassesTest.cpp.o 
ccache /usr/bin/c++ -DGTEST_HAS_RTTI=0 -DLLVM_BUILD_STATIC -D_DEBUG -D_GLIBCXX_ASSERTIONS -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/home/botworker/builds/openmp-offload-amdgpu-runtime-2/llvm.build/unittests/ADT -I/home/botworker/builds/openmp-offload-amdgpu-runtime-2/llvm.src/llvm/unittests/ADT -I/home/botworker/builds/openmp-offload-amdgpu-runtime-2/llvm.build/include -I/home/botworker/builds/openmp-offload-amdgpu-runtime-2/llvm.src/llvm/include -I/home/botworker/builds/openmp-offload-amdgpu-runtime-2/llvm.src/third-party/unittest/googletest/include -I/home/botworker/builds/openmp-offload-amdgpu-runtime-2/llvm.src/third-party/unittest/googlemock/include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -fno-lifetime-dse -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-uninitialized -Wno-nonnull -Wno-class-memaccess -Wno-redundant-move -Wno-pessimizing-move -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wno-misleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -O3 -DNDEBUG  -Wno-dangling-else -Wno-variadic-macros -fno-exceptions -funwind-tables -fno-rtti -UNDEBUG -Wno-suggest-override -std=c++17 -MD -MT unittests/ADT/CMakeFiles/ADTTests.dir/EquivalenceClassesTest.cpp.o -MF unittests/ADT/CMakeFiles/ADTTests.dir/EquivalenceClassesTest.cpp.o.d -o unittests/ADT/CMakeFiles/ADTTests.dir/EquivalenceClassesTest.cpp.o -c /home/botworker/builds/openmp-offload-amdgpu-runtime-2/llvm.src/llvm/unittests/ADT/EquivalenceClassesTest.cpp
In file included from /home/botworker/builds/openmp-offload-amdgpu-runtime-2/llvm.src/third-party/unittest/googlemock/include/gmock/gmock.h:61,
                 from /home/botworker/builds/openmp-offload-amdgpu-runtime-2/llvm.src/llvm/unittests/ADT/EquivalenceClassesTest.cpp:10:
/home/botworker/builds/openmp-offload-amdgpu-runtime-2/llvm.src/third-party/unittest/googlemock/include/gmock/gmock-more-matchers.h: In instantiation of ‘bool testing::internal::IsEmptyMatcher::MatchAndExplain(const MatcheeContainerType&, testing::MatchResultListener*) const [with MatcheeContainerType = llvm::iterator_range<llvm::EquivalenceClasses<int>::member_iterator>]’:
/home/botworker/builds/openmp-offload-amdgpu-runtime-2/llvm.src/third-party/unittest/googletest/include/gtest/gtest-matchers.h:647:35:   required from ‘bool testing::PolymorphicMatcher<Impl>::MonomorphicImpl<T>::MatchAndExplain(T, testing::MatchResultListener*) const [with T = const llvm::iterator_range<llvm::EquivalenceClasses<int>::member_iterator>&; Impl = testing::internal::IsEmptyMatcher]’
/home/botworker/builds/openmp-offload-amdgpu-runtime-2/llvm.src/third-party/unittest/googletest/include/gtest/gtest-matchers.h:646:10:   required from here
/home/botworker/builds/openmp-offload-amdgpu-runtime-2/llvm.src/third-party/unittest/googlemock/include/gmock/gmock-more-matchers.h:73:40: error: ‘const class llvm::iterator_range<llvm::EquivalenceClasses<int>::member_iterator>’ has no member named ‘size’
   73 |     *listener << "whose size is " << c.size();
      |                                      ~~^~~~
[642/696] Building CXX object unittests/Analysis/CMakeFiles/AnalysisTests.dir/DDGTest.cpp.o
[643/696] Building CXX object unittests/Transforms/Utils/CMakeFiles/UtilsTests.dir/LoopUtilsTest.cpp.o
[644/696] Building CXX object unittests/Analysis/CMakeFiles/AnalysisTests.dir/VectorUtilsTest.cpp.o
[645/696] Building CXX object unittests/Analysis/CMakeFiles/AnalysisTests.dir/LastRunTrackingAnalysisTest.cpp.o
[646/696] Building CXX object unittests/Transforms/Vectorize/CMakeFiles/VectorizeTests.dir/VPDomTreeTest.cpp.o
[647/696] Building CXX object unittests/Transforms/Vectorize/SandboxVectorizer/CMakeFiles/SandboxVectorizerTests.dir/InstrMapsTest.cpp.o
[648/696] Building CXX object unittests/Transforms/Vectorize/CMakeFiles/VectorizeTests.dir/VPlanVerifierTest.cpp.o
[649/696] Building CXX object unittests/Analysis/CMakeFiles/AnalysisTests.dir/ReplaceWithVecLibTest.cpp.o
[650/696] Building CXX object unittests/SandboxIR/CMakeFiles/SandboxIRTests.dir/UtilsTest.cpp.o
[651/696] Building CXX object unittests/Analysis/CMakeFiles/AnalysisTests.dir/PluginInlineOrderAnalysisTest.cpp.o
[652/696] Building CXX object unittests/Transforms/Vectorize/CMakeFiles/VectorizeTests.dir/VPlanHCFGTest.cpp.o
[653/696] Building CXX object unittests/Transforms/Scalar/CMakeFiles/ScalarTests.dir/LICMTest.cpp.o
[654/696] Building CXX object unittests/Transforms/Vectorize/CMakeFiles/VectorizeTests.dir/VPlanSlpTest.cpp.o
[655/696] Building CXX object unittests/Analysis/CMakeFiles/AnalysisTests.dir/PluginInlineAdvisorAnalysisTest.cpp.o
[656/696] Building CXX object unittests/Transforms/Coroutines/CMakeFiles/CoroTests.dir/ExtraRematTest.cpp.o
[657/696] Building CXX object unittests/Transforms/Vectorize/SandboxVectorizer/CMakeFiles/SandboxVectorizerTests.dir/VecUtilsTest.cpp.o
[658/696] Building CXX object unittests/IR/CMakeFiles/IRTests.dir/VFABIDemanglerTest.cpp.o
[659/696] Building CXX object unittests/Transforms/Utils/CMakeFiles/UtilsTests.dir/MemTransferLowering.cpp.o
[660/696] Building CXX object unittests/Passes/Plugins/CMakeFiles/PluginsTests.dir/PluginsTest.cpp.o
[661/696] Building CXX object unittests/Transforms/Vectorize/SandboxVectorizer/CMakeFiles/SandboxVectorizerTests.dir/SeedCollectorTest.cpp.o
[662/696] Building CXX object unittests/Target/X86/CMakeFiles/X86Tests.dir/TernlogTest.cpp.o
[663/696] Building CXX object unittests/Transforms/Vectorize/SandboxVectorizer/CMakeFiles/SandboxVectorizerTests.dir/LegalityTest.cpp.o
In file included from /home/botworker/builds/openmp-offload-amdgpu-runtime-2/llvm.src/llvm/unittests/Transforms/Vectorize/SandboxVectorizer/LegalityTest.cpp:9:
/home/botworker/builds/openmp-offload-amdgpu-runtime-2/llvm.src/llvm/include/llvm/Transforms/Vectorize/SandboxVectorizer/Legality.h:186:33: warning: ‘maybe_unused’ attribute ignored [-Wattributes]
  186 |   [[maybe_unused]] ResultReason Reason;
      |                                 ^~~~~~
[664/696] Building CXX object unittests/CodeGen/CMakeFiles/CodeGenTests.dir/PassManagerTest.cpp.o
[665/696] Building CXX object unittests/CodeGen/CMakeFiles/CodeGenTests.dir/MachineDomTreeUpdaterTest.cpp.o
[666/696] Building CXX object unittests/Analysis/CMakeFiles/AnalysisTests.dir/FunctionPropertiesAnalysisTest.cpp.o

```

</details>

https://github.com/llvm/llvm-project/pull/130139