[llvm] [EquivClasses] Introduce members iterator-helper (PR #130139)

Fri Mar 7 09:29:36 PST 2025

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `llvm-clang-aarch64-darwin` running on `doug-worker-5` while building `llvm` at step 5 "build-unified-tree".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/190/builds/15931

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 5 (build-unified-tree) failure: build (failure)
...
179.584 [833/8/5164] Building CXX object unittests/ADT/CMakeFiles/ADTTests.dir/SimpleIListTest.cpp.o
179.612 [832/8/5165] Building CXX object unittests/ADT/CMakeFiles/ADTTests.dir/SmallPtrSetTest.cpp.o
179.636 [831/8/5166] Building CXX object unittests/ADT/CMakeFiles/ADTTests.dir/SmallSetTest.cpp.o
179.662 [830/8/5167] Building CXX object unittests/ADT/CMakeFiles/ADTTests.dir/SmallStringTest.cpp.o
179.678 [829/8/5168] Building CXX object unittests/ADT/CMakeFiles/ADTTests.dir/SmallVectorExtrasTest.cpp.o
179.704 [828/8/5169] Building CXX object unittests/ADT/CMakeFiles/ADTTests.dir/SmallVectorTest.cpp.o
179.730 [827/8/5170] Building CXX object unittests/ADT/CMakeFiles/ADTTests.dir/SparseBitVectorTest.cpp.o
179.758 [826/8/5171] Building CXX object unittests/ADT/CMakeFiles/ADTTests.dir/SparseMultiSetTest.cpp.o
179.783 [825/8/5172] Building CXX object unittests/ADT/CMakeFiles/ADTTests.dir/SparseSetTest.cpp.o
179.789 [824/8/5173] Building CXX object unittests/ADT/CMakeFiles/ADTTests.dir/EquivalenceClassesTest.cpp.o
FAILED: unittests/ADT/CMakeFiles/ADTTests.dir/EquivalenceClassesTest.cpp.o 
CCACHE_CPP2=yes CCACHE_HASHDIR=yes /opt/homebrew/bin/ccache /usr/bin/clang++ -DGTEST_HAS_RTTI=0 -DLLVM_BUILD_STATIC -D_DEBUG -D_GLIBCXX_ASSERTIONS -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/Users/buildbot/buildbot-root/aarch64-darwin/build/unittests/ADT -I/Users/buildbot/buildbot-root/aarch64-darwin/llvm-project/llvm/unittests/ADT -I/Users/buildbot/buildbot-root/aarch64-darwin/build/include -I/Users/buildbot/buildbot-root/aarch64-darwin/llvm-project/llvm/include -I/Users/buildbot/buildbot-root/aarch64-darwin/llvm-project/third-party/unittest/googletest/include -I/Users/buildbot/buildbot-root/aarch64-darwin/llvm-project/third-party/unittest/googlemock/include -isystem /opt/homebrew/include -fPIC -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wc++98-compat-extra-semi -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -O3 -DNDEBUG -std=c++17 -arch arm64 -isysroot /Library/Developer/CommandLineTools/SDKs/MacOSX14.4.sdk  -Wno-variadic-macros -Wno-gnu-zero-variadic-macro-arguments -fno-exceptions -funwind-tables -fno-rtti -UNDEBUG -Wno-suggest-override -MD -MT unittests/ADT/CMakeFiles/ADTTests.dir/EquivalenceClassesTest.cpp.o -MF unittests/ADT/CMakeFiles/ADTTests.dir/EquivalenceClassesTest.cpp.o.d -o unittests/ADT/CMakeFiles/ADTTests.dir/EquivalenceClassesTest.cpp.o -c /Users/buildbot/buildbot-root/aarch64-darwin/llvm-project/llvm/unittests/ADT/EquivalenceClassesTest.cpp
In file included from /Users/buildbot/buildbot-root/aarch64-darwin/llvm-project/llvm/unittests/ADT/EquivalenceClassesTest.cpp:10:
In file included from /Users/buildbot/buildbot-root/aarch64-darwin/llvm-project/third-party/unittest/googlemock/include/gmock/gmock.h:61:
/Users/buildbot/buildbot-root/aarch64-darwin/llvm-project/third-party/unittest/googlemock/include/gmock/gmock-more-matchers.h:73:40: error: no member named 'size' in 'llvm::iterator_range<llvm::EquivalenceClasses<int>::member_iterator>'
    *listener << "whose size is " << c.size();
                                     ~ ^
/Users/buildbot/buildbot-root/aarch64-darwin/llvm-project/third-party/unittest/googletest/include/gtest/gtest-matchers.h:647:20: note: in instantiation of function template specialization 'testing::internal::IsEmptyMatcher::MatchAndExplain<llvm::iterator_range<llvm::EquivalenceClasses<int>::member_iterator>>' requested here
      return impl_.MatchAndExplain(x, listener);
                   ^
/Users/buildbot/buildbot-root/aarch64-darwin/llvm-project/third-party/unittest/googletest/include/gtest/gtest-matchers.h:638:14: note: in instantiation of member function 'testing::PolymorphicMatcher<testing::internal::IsEmptyMatcher>::MonomorphicImpl<const llvm::iterator_range<llvm::EquivalenceClasses<int>::member_iterator> &>::MatchAndExplain' requested here
    explicit MonomorphicImpl(const Impl& impl) : impl_(impl) {}
             ^
/Users/buildbot/buildbot-root/aarch64-darwin/llvm-project/third-party/unittest/googletest/include/gtest/gtest-matchers.h:631:27: note: in instantiation of member function 'testing::PolymorphicMatcher<testing::internal::IsEmptyMatcher>::MonomorphicImpl<const llvm::iterator_range<llvm::EquivalenceClasses<int>::member_iterator> &>::MonomorphicImpl' requested here
    return Matcher<T>(new MonomorphicImpl<const T&>(impl_));
                          ^
/Users/buildbot/buildbot-root/aarch64-darwin/llvm-project/third-party/unittest/googlemock/include/gmock/gmock-matchers.h:373:12: note: in instantiation of function template specialization 'testing::PolymorphicMatcher<testing::internal::IsEmptyMatcher>::operator Matcher<const llvm::iterator_range<llvm::EquivalenceClasses<int>::member_iterator> &>' requested here
    return polymorphic_matcher_or_value;
           ^
/Users/buildbot/buildbot-root/aarch64-darwin/llvm-project/third-party/unittest/googlemock/include/gmock/gmock-matchers.h:355:12: note: in instantiation of function template specialization 'testing::internal::MatcherCastImpl<const llvm::iterator_range<llvm::EquivalenceClasses<int>::member_iterator> &, testing::PolymorphicMatcher<testing::internal::IsEmptyMatcher>>::CastImpl<false>' requested here
    return CastImpl(polymorphic_matcher_or_value,
           ^
/Users/buildbot/buildbot-root/aarch64-darwin/llvm-project/third-party/unittest/googlemock/include/gmock/gmock-matchers.h:515:43: note: in instantiation of member function 'testing::internal::MatcherCastImpl<const llvm::iterator_range<llvm::EquivalenceClasses<int>::member_iterator> &, testing::PolymorphicMatcher<testing::internal::IsEmptyMatcher>>::Cast' requested here
  return internal::MatcherCastImpl<T, M>::Cast(matcher);
                                          ^
/Users/buildbot/buildbot-root/aarch64-darwin/llvm-project/third-party/unittest/googlemock/include/gmock/gmock-matchers.h:522:10: note: in instantiation of function template specialization 'testing::MatcherCast<const llvm::iterator_range<llvm::EquivalenceClasses<int>::member_iterator> &, testing::PolymorphicMatcher<testing::internal::IsEmptyMatcher>>' requested here
  return MatcherCast<T>(polymorphic_matcher_or_value);
         ^
/Users/buildbot/buildbot-root/aarch64-darwin/llvm-project/third-party/unittest/googlemock/include/gmock/gmock-matchers.h:1591:39: note: in instantiation of function template specialization 'testing::SafeMatcherCast<const llvm::iterator_range<llvm::EquivalenceClasses<int>::member_iterator> &, testing::PolymorphicMatcher<testing::internal::IsEmptyMatcher>>' requested here
    const Matcher<const T&> matcher = SafeMatcherCast<const T&>(matcher_);
                                      ^
/Users/buildbot/buildbot-root/aarch64-darwin/llvm-project/llvm/unittests/ADT/EquivalenceClassesTest.cpp:80:3: note: in instantiation of function template specialization 'testing::internal::PredicateFormatterFromMatcher<testing::PolymorphicMatcher<testing::internal::IsEmptyMatcher>>::operator()<llvm::iterator_range<llvm::EquivalenceClasses<int>::member_iterator>>' requested here
  EXPECT_THAT(EC.members(EC.end()), testing::IsEmpty());
  ^
/Users/buildbot/buildbot-root/aarch64-darwin/llvm-project/third-party/unittest/googlemock/include/gmock/gmock-matchers.h:5495:3: note: expanded from macro 'EXPECT_THAT'
  EXPECT_PRED_FORMAT1(              \
  ^
/Users/buildbot/buildbot-root/aarch64-darwin/llvm-project/third-party/unittest/googletest/include/gtest/gtest_pred_impl.h:109:3: note: expanded from macro 'EXPECT_PRED_FORMAT1'
  GTEST_PRED_FORMAT1_(pred_format, v1, GTEST_NONFATAL_FAILURE_)

```

</details>

https://github.com/llvm/llvm-project/pull/130139