[llvm] [MachineCopyPropagation] Recognise and delete no-op moves produced after forwarded uses (PR #129889)

[Alex Bradbury via llvm-commits]

================
@@ -971,6 +971,18 @@ void MachineCopyPropagation::ForwardCopyPropagateBlock(MachineBasicBlock &MBB) {
 
     forwardUses(MI);
 
+    // It's possible that the previous transformation has resulted in a no-op
+    // register move (i.e. one where source and destination registers are the
+    // same). If so, delete it.
+    CopyOperands = isCopyInstr(MI, *TII, UseCopyInstr);
----------------
asb wrote:

I'm a bit confused here - this logic needs to go after the forwardUses just above, so I don't think I have any flexibility to move it up to where you suggest?

https://github.com/llvm/llvm-project/pull/129889