[llvm] [EquivClasses] Fix signature of operator= (PR #130140)
Ramkumar Ramachandra via llvm-commits
llvm-commits at lists.llvm.org
Fri Mar 7 03:04:55 PST 2025
https://github.com/artagnon updated https://github.com/llvm/llvm-project/pull/130140
>From 64a286fbfa38bc0c38cc8a28070af05ff72a51d8 Mon Sep 17 00:00:00 2001
From: Ramkumar Ramachandra <ramkumar.ramachandra at codasip.com>
Date: Thu, 6 Mar 2025 16:45:26 +0000
Subject: [PATCH 1/2] [EquivClasses] Fix signature of operator= (NFC)
---
llvm/include/llvm/ADT/EquivalenceClasses.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/llvm/include/llvm/ADT/EquivalenceClasses.h b/llvm/include/llvm/ADT/EquivalenceClasses.h
index 4f98b84cf97d2..c375d6e77b12a 100644
--- a/llvm/include/llvm/ADT/EquivalenceClasses.h
+++ b/llvm/include/llvm/ADT/EquivalenceClasses.h
@@ -144,7 +144,7 @@ class EquivalenceClasses {
operator=(RHS);
}
- const EquivalenceClasses &operator=(const EquivalenceClasses &RHS) {
+ EquivalenceClasses &operator=(const EquivalenceClasses &RHS) {
TheMapping.clear();
for (iterator I = RHS.begin(), E = RHS.end(); I != E; ++I)
if (I->isLeader()) {
>From 700a266bbbf7fbf09e1b167db02647d250b216d6 Mon Sep 17 00:00:00 2001
From: Ramkumar Ramachandra <ramkumar.ramachandra at codasip.com>
Date: Fri, 7 Mar 2025 11:03:54 +0000
Subject: [PATCH 2/2] [EquivClasses] Add unit-test
---
llvm/unittests/ADT/EquivalenceClassesTest.cpp | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/llvm/unittests/ADT/EquivalenceClassesTest.cpp b/llvm/unittests/ADT/EquivalenceClassesTest.cpp
index 70e161a03d988..bfb7c8d185fc8 100644
--- a/llvm/unittests/ADT/EquivalenceClassesTest.cpp
+++ b/llvm/unittests/ADT/EquivalenceClassesTest.cpp
@@ -13,6 +13,15 @@ using namespace llvm;
namespace llvm {
+TEST(EquivalenceClassesTest, CopyAssignemnt) {
+ EquivalenceClasses<int> EC, Copy;
+ EC.insert(1);
+ EC.insert(4);
+ EquivalenceClasses<int> &Ref = Copy = EC;
+ EXPECT_EQ(Copy.getNumClasses(), 2u);
+ EXPECT_EQ(&Ref, &Copy);
+}
+
TEST(EquivalenceClassesTest, NoMerges) {
EquivalenceClasses<int> EqClasses;
// Until we merged any sets, check that every element is only equivalent to
More information about the llvm-commits
mailing list