[llvm] Runtimes: specify whether to leverage a target triple for default builds (PR #130170)

[Eric Miotto via llvm-commits]

https://github.com/edymtt created https://github.com/llvm/llvm-project/pull/130170

The default builds for runtimes currently set `CMAKE_C_COMPILER_TARGET` and `CMAKE_CXX_COMPILER_TARGET`, which causes all compilation commands to have a matching `--target` argument -- this can cause issues when building for Apple platforms, where that interferes with the detection of the SDKs and subsequent builds.

rdar://146304200

>From 75a2559d4acc8679ab507b83077291793c2c6a7c Mon Sep 17 00:00:00 2001
From: Eric Miotto <emiotto at apple.com>
Date: Thu, 6 Mar 2025 12:20:36 -0800
Subject: [PATCH] Runtimes: specify whether to leverage a target triple for
 default builds

The default builds for runtimes currently set `CMAKE_C_COMPILER_TARGET`
and `CMAKE_CXX_COMPILER_TARGET`, which causes all compilation commands
to have a matching `--target` argument -- this can cause issues when
building for Apple platforms, where that interferes with the detection
of the SDKs and subsequent builds.

rdar://146304200
---
 llvm/CMakeLists.txt          |  5 +++++
 llvm/runtimes/CMakeLists.txt | 17 +++++++++++++++--
 2 files changed, 20 insertions(+), 2 deletions(-)

diff --git a/llvm/CMakeLists.txt b/llvm/CMakeLists.txt
index 9a5cd1d985886..3951f4d4a057c 100644
--- a/llvm/CMakeLists.txt
+++ b/llvm/CMakeLists.txt
@@ -1004,6 +1004,11 @@ message(STATUS "LLVM default target triple: ${LLVM_DEFAULT_TARGET_TRIPLE}")
 
 set(LLVM_TARGET_TRIPLE "${LLVM_DEFAULT_TARGET_TRIPLE}")
 
+set(LLVM_USE_TARGET_TRIPLE_WHEN_BUILDING_DEFAULT_TARGET_FOR_RUNTIMES
+    ON CACHE BOOL
+    "Disable this if the underlying runtime build detects and builds for multiple platform
+    at once (like it's the case for compiler-rt on Apple platforms)")
+
 if(WIN32 OR CYGWIN)
   if(BUILD_SHARED_LIBS OR LLVM_BUILD_LLVM_DYLIB)
     set(LLVM_ENABLE_PLUGINS_default ON)
diff --git a/llvm/runtimes/CMakeLists.txt b/llvm/runtimes/CMakeLists.txt
index 77a82ed196cd9..aa397010f78d2 100644
--- a/llvm/runtimes/CMakeLists.txt
+++ b/llvm/runtimes/CMakeLists.txt
@@ -82,11 +82,22 @@ macro(set_enable_per_target_runtime_dir)
   endif()
 endmacro()
 
+macro(set_target_triple_for_default_runtime_build)
+  if(NOT DEFINED LLVM_USE_TARGET_TRIPLE_WHEN_BUILDING_DEFAULT_TARGET_FOR_RUNTIMES
+     OR "${LLVM_USE_TARGET_TRIPLE_WHEN_BUILDING_DEFAULT_TARGET_FOR_RUNTIMES}")
+    list(APPEND TARGET_TRIPLE_ARGUMENTS TARGET_TRIPLE ${LLVM_TARGET_TRIPLE})
+  else()
+    list(APPEND TARGET_TRIPLE_ARGUMENTS)
+  endif()
+endmacro()
+
 function(builtin_default_target compiler_rt_path)
   cmake_parse_arguments(ARG "" "" "DEPENDS" ${ARGN})
 
   set_enable_per_target_runtime_dir()
 
+  set_target_triple_for_default_runtime_build()
+
   llvm_ExternalProject_Add(builtins
                            ${compiler_rt_path}/lib/builtins
                            DEPENDS ${ARG_DEPENDS}
@@ -103,7 +114,7 @@ function(builtin_default_target compiler_rt_path)
                                                 DARWIN
                                                 SANITIZER
                            USE_TOOLCHAIN
-                           TARGET_TRIPLE ${LLVM_TARGET_TRIPLE}
+                           ${TARGET_TRIPLE_ARGUMENTS}
                            FOLDER "Compiler-RT"
                            ${EXTRA_ARGS})
 endfunction()
@@ -258,6 +269,8 @@ function(runtime_default_target)
 
   set_enable_per_target_runtime_dir()
 
+  set_target_triple_for_default_runtime_build()
+
   llvm_ExternalProject_Add(runtimes
                            ${CMAKE_CURRENT_SOURCE_DIR}/../../runtimes
                            DEPENDS ${ARG_DEPENDS}
@@ -287,7 +300,7 @@ function(runtime_default_target)
                                          ${SUB_CHECK_TARGETS}
                                          ${SUB_INSTALL_TARGETS}
                            USE_TOOLCHAIN
-                           TARGET_TRIPLE ${LLVM_TARGET_TRIPLE}
+                           ${TARGET_TRIPLE_ARGUMENTS}
                            FOLDER "Runtimes"
                            ${EXTRA_ARGS} ${ARG_EXTRA_ARGS})
 endfunction()