[llvm] [MCA] Adding missing instructions in AArch64 Neoverse V1 tests (PR #128892)
David Green via llvm-commits
llvm-commits at lists.llvm.org
Thu Mar 6 03:35:02 PST 2025
davemgreen wrote:
Thanks - I see part of the confusion was my fault as there isn't an existing test for bl, only for b and blr. The new test looks OK, although I would move it into the `Unconditional branch (immediate)` section (a label is just an immediate, after all).
For the new crc instructions added - did you intent to test the forwarding of crcs into one another? If not it might be better to make sure there is test coverage in V1-basic-instructions.s instead. Either way they are not the biggest deal and this looks good to me otherwise.
https://github.com/llvm/llvm-project/pull/128892
More information about the llvm-commits
mailing list