[llvm] [llvm-strip] Let llvm-strip continue on encountering an error (PR #129531)
James Henderson via llvm-commits
llvm-commits at lists.llvm.org
Thu Mar 6 03:28:23 PST 2025
jh7370 wrote:
> Addressed Nit. From my understanding, all commits need to be merged at the end so I rebased and force pushed (unless I was wrong?)
You're right in that the final commit that lands in main should be a single distinct commit (so all fixups should be merged). However, the default merge option we use in GitHub is "Squash and Merge" which squashes the commits into a single commit and then rebases it on main, before pushing, so there's no need to do it manually.
> Additionally, my email address should be public now. And I would appreciate you merging.
Noted. I'll let the pre-merge checks finish before doing the merge.
https://github.com/llvm/llvm-project/pull/129531
More information about the llvm-commits
mailing list