[llvm] [llvm][ELF]Add Shdr check for getBuildID (PR #126537)
Ruoyu Qiu via llvm-commits
llvm-commits at lists.llvm.org
Thu Mar 6 01:22:20 PST 2025
cabbaken wrote:
> Could you do a merge commit from main into your branch, to see if it fixes the issues that the pre-merge tests were highlighting before, please? (Once you've fixed the yaml2obj issue anyway)
That’s exactly what I planned to do.
> You're touching on a whole can of worms there, as there are many different testing philosophies that suggest you should or shouldn't have cases that test lower-level function behaviours. For example, if you were to write your tests without knowing what code it uses under the hood, you would write a whole suite of tests that cover various edge cases that might actually end up testing the same cases as are tested elsewhere.
>
> In this case though, I agree it probably makes sense to avoid additional tests for that specific case IF there are already existing tests that cover that behaviour.
Got it!
So my only task now is to fix yaml2obj and verify that this PR passes the checks, right?
https://github.com/llvm/llvm-project/pull/126537
More information about the llvm-commits
mailing list