[llvm] [llvm-strip] Let llvm-strip continue on encountering an error (PR #129531)

James Henderson via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 6 00:51:33 PST 2025


https://github.com/jh7370 commented:

A couple of process points:
1) Per the [documented LLVM policy](https://llvm.org/docs/GitHub.html#updating-pull-requests), please use fixup commits to make updates and avoid force pushes. Force pushing makes it difficult to review what has changed since the previous version of the PR, making reviewers' lives harder.
2) Please don't click the "Resolve Conversation" button when you've addressed a request. As a reviewer, I use unresolved conversations to track what changes have been requested and then can review any changes against these conversations to see if the made changes were what were requested. See https://discourse.llvm.org/t/rfc-github-pr-resolve-conversation-button/73178 for more discussion.

Aside from that and one nit in the test, LGTM. Do you need help merging?

https://github.com/llvm/llvm-project/pull/129531


More information about the llvm-commits mailing list