[llvm] [Github] Prefer ubuntu-24.04 over ubuntu-latest (PR #129936)
Aiden Grossman via llvm-commits
llvm-commits at lists.llvm.org
Wed Mar 5 13:02:00 PST 2025
https://github.com/boomanaiden154 created https://github.com/llvm/llvm-project/pull/129936
This patch replaces all instances of ubuntu-latest with ubuntu-24.04 (outside of the entries in libc++) based on the guidelines in the LLVM CI best practices doc (https://llvm.org/docs/CIBestPractices.html).
>From c97eedd9880becb5d6fb541cc6beacc68f31fb90 Mon Sep 17 00:00:00 2001
From: Aiden Grossman <aidengrossman at google.com>
Date: Wed, 5 Mar 2025 21:00:12 +0000
Subject: [PATCH] [Github] Prefer ubuntu-24.04 over ubuntu-latest
This patch replaces all instances of ubuntu-latest with ubuntu-24.04
(outside of the entries in libc++) based on the guidelines in the
LLVM CI best practices doc (https://llvm.org/docs/CIBestPractices.html).
---
.github/workflows/build-metrics-container.yml | 2 +-
.github/workflows/docs.yml | 2 +-
.github/workflows/email-check.yaml | 2 +-
.github/workflows/issue-release-workflow.yml | 2 +-
.github/workflows/issue-subscriber.yml | 2 +-
.github/workflows/issue-write.yml | 2 +-
.github/workflows/libclang-abi-tests.yml | 6 +++---
.github/workflows/llvm-bugs.yml | 2 +-
.github/workflows/llvm-project-tests.yml | 4 ++--
.github/workflows/llvm-tests.yml | 6 +++---
.github/workflows/merged-prs.yml | 2 +-
.github/workflows/new-issues.yml | 2 +-
.github/workflows/new-prs.yml | 4 ++--
.github/workflows/pr-code-format.yml | 2 +-
.github/workflows/pr-request-release-note.yml | 2 +-
.github/workflows/pr-subscriber.yml | 2 +-
.github/workflows/release-documentation.yml | 2 +-
.github/workflows/release-doxygen.yml | 2 +-
.github/workflows/release-lit.yml | 2 +-
.github/workflows/release-sources.yml | 4 ++--
.github/workflows/release-tasks.yml | 4 ++--
.github/workflows/scorecard.yml | 2 +-
.github/workflows/version-check.yml | 2 +-
23 files changed, 31 insertions(+), 31 deletions(-)
diff --git a/.github/workflows/build-metrics-container.yml b/.github/workflows/build-metrics-container.yml
index 7924779fc3f8d..af4d599f76417 100644
--- a/.github/workflows/build-metrics-container.yml
+++ b/.github/workflows/build-metrics-container.yml
@@ -20,7 +20,7 @@ on:
jobs:
build-metrics-container:
if: github.repository_owner == 'llvm'
- runs-on: ubuntu-latest
+ runs-on: ubuntu-24.04
outputs:
container-name: ${{ steps.vars.outputs.container-name }}
container-name-tag: ${{ steps.vars.outputs.container-name-tag }}
diff --git a/.github/workflows/docs.yml b/.github/workflows/docs.yml
index 4cf1c356cfe23..b5f76d761af22 100644
--- a/.github/workflows/docs.yml
+++ b/.github/workflows/docs.yml
@@ -51,7 +51,7 @@ on:
jobs:
check-docs-build:
name: "Test documentation build"
- runs-on: ubuntu-latest
+ runs-on: ubuntu-24.04
if: github.repository == 'llvm/llvm-project'
steps:
# Don't fetch before checking for file changes to force the file changes
diff --git a/.github/workflows/email-check.yaml b/.github/workflows/email-check.yaml
index 5719203c5f908..f4481d5cf5583 100644
--- a/.github/workflows/email-check.yaml
+++ b/.github/workflows/email-check.yaml
@@ -10,7 +10,7 @@ permissions:
jobs:
validate_email:
- runs-on: ubuntu-latest
+ runs-on: ubuntu-24.04
if: github.repository == 'llvm/llvm-project'
steps:
- name: Fetch LLVM sources
diff --git a/.github/workflows/issue-release-workflow.yml b/.github/workflows/issue-release-workflow.yml
index 1582d06a97d3f..efd045990d013 100644
--- a/.github/workflows/issue-release-workflow.yml
+++ b/.github/workflows/issue-release-workflow.yml
@@ -32,7 +32,7 @@ env:
jobs:
backport-commits:
name: Backport Commits
- runs-on: ubuntu-latest
+ runs-on: ubuntu-24.04
permissions:
issues: write
pull-requests: write
diff --git a/.github/workflows/issue-subscriber.yml b/.github/workflows/issue-subscriber.yml
index 2fb8ad18eb0ac..de1c45c944960 100644
--- a/.github/workflows/issue-subscriber.yml
+++ b/.github/workflows/issue-subscriber.yml
@@ -10,7 +10,7 @@ permissions:
jobs:
auto-subscribe:
- runs-on: ubuntu-latest
+ runs-on: ubuntu-24.04
if: github.repository == 'llvm/llvm-project'
steps:
- name: Checkout Automation Script
diff --git a/.github/workflows/issue-write.yml b/.github/workflows/issue-write.yml
index e7583fae5e990..f5c60f51ca213 100644
--- a/.github/workflows/issue-write.yml
+++ b/.github/workflows/issue-write.yml
@@ -14,7 +14,7 @@ permissions:
jobs:
pr-comment:
- runs-on: ubuntu-latest
+ runs-on: ubuntu-24.04
permissions:
pull-requests: write
if: >
diff --git a/.github/workflows/libclang-abi-tests.yml b/.github/workflows/libclang-abi-tests.yml
index 8995d52b9925f..440af1691deed 100644
--- a/.github/workflows/libclang-abi-tests.yml
+++ b/.github/workflows/libclang-abi-tests.yml
@@ -27,7 +27,7 @@ concurrency:
jobs:
abi-dump-setup:
if: github.repository_owner == 'llvm'
- runs-on: ubuntu-latest
+ runs-on: ubuntu-24.04
outputs:
BASELINE_REF: ${{ steps.vars.outputs.BASELINE_REF }}
ABI_HEADERS: ${{ steps.vars.outputs.ABI_HEADERS }}
@@ -83,7 +83,7 @@ jobs:
abi-dump:
if: github.repository_owner == 'llvm'
needs: abi-dump-setup
- runs-on: ubuntu-latest
+ runs-on: ubuntu-24.04
strategy:
matrix:
name:
@@ -137,7 +137,7 @@ jobs:
abi-compare:
if: github.repository_owner == 'llvm'
- runs-on: ubuntu-latest
+ runs-on: ubuntu-24.04
needs:
- abi-dump-setup
- abi-dump
diff --git a/.github/workflows/llvm-bugs.yml b/.github/workflows/llvm-bugs.yml
index a54e52456e860..5470662c97628 100644
--- a/.github/workflows/llvm-bugs.yml
+++ b/.github/workflows/llvm-bugs.yml
@@ -11,7 +11,7 @@ on:
jobs:
auto-subscribe:
- runs-on: ubuntu-latest
+ runs-on: ubuntu-24.04
if: github.repository == 'llvm/llvm-project'
steps:
- uses: actions/setup-node at 1d0ff469b7ec7b3cb9d8673fde0c81c44821de2a # v4.2.0
diff --git a/.github/workflows/llvm-project-tests.yml b/.github/workflows/llvm-project-tests.yml
index d857995d325d0..3da6743c49e25 100644
--- a/.github/workflows/llvm-project-tests.yml
+++ b/.github/workflows/llvm-project-tests.yml
@@ -14,7 +14,7 @@ on:
required: false
os_list:
required: false
- default: '["ubuntu-latest", "windows-2019", "macOS-13"]'
+ default: '["ubuntu-24.04", "windows-2019", "macOS-13"]'
python_version:
required: false
type: string
@@ -39,7 +39,7 @@ on:
type: string
# Use windows-2019 due to:
# https://developercommunity.visualstudio.com/t/Prev-Issue---with-__assume-isnan-/1597317
- # Use ubuntu-22.04 rather than ubuntu-latest to match the ubuntu
+ # Use ubuntu-22.04 rather than ubuntu-24.04 to match the ubuntu
# version in the CI container. Without this, setup-python tries
# to install a python version linked against a newer version of glibc.
# TODO(boomanaiden154): Bump the Ubuntu version once the version in the
diff --git a/.github/workflows/llvm-tests.yml b/.github/workflows/llvm-tests.yml
index 2c41368369ce8..464b4c726b966 100644
--- a/.github/workflows/llvm-tests.yml
+++ b/.github/workflows/llvm-tests.yml
@@ -27,7 +27,7 @@ concurrency:
jobs:
abi-dump-setup:
if: github.repository_owner == 'llvm'
- runs-on: ubuntu-latest
+ runs-on: ubuntu-24.04
outputs:
BASELINE_REF: ${{ steps.vars.outputs.BASELINE_REF }}
ABI_HEADERS: ${{ steps.vars.outputs.ABI_HEADERS }}
@@ -71,7 +71,7 @@ jobs:
abi-dump:
if: github.repository_owner == 'llvm'
needs: abi-dump-setup
- runs-on: ubuntu-latest
+ runs-on: ubuntu-24.04
strategy:
matrix:
name:
@@ -141,7 +141,7 @@ jobs:
abi-compare:
if: github.repository_owner == 'llvm'
- runs-on: ubuntu-latest
+ runs-on: ubuntu-24.04
needs:
- abi-dump-setup
- abi-dump
diff --git a/.github/workflows/merged-prs.yml b/.github/workflows/merged-prs.yml
index aa559e4b75a76..c771736389802 100644
--- a/.github/workflows/merged-prs.yml
+++ b/.github/workflows/merged-prs.yml
@@ -13,7 +13,7 @@ on:
jobs:
buildbot_comment:
- runs-on: ubuntu-latest
+ runs-on: ubuntu-24.04
permissions:
pull-requests: write
if: >-
diff --git a/.github/workflows/new-issues.yml b/.github/workflows/new-issues.yml
index 3cac57e268513..8480a657cc717 100644
--- a/.github/workflows/new-issues.yml
+++ b/.github/workflows/new-issues.yml
@@ -10,7 +10,7 @@ jobs:
automate-issues-labels:
permissions:
issues: write
- runs-on: ubuntu-latest
+ runs-on: ubuntu-24.04
if: github.repository == 'llvm/llvm-project'
steps:
- uses: llvm/actions/issue-labeler at main
diff --git a/.github/workflows/new-prs.yml b/.github/workflows/new-prs.yml
index 3f042e7616011..935598e410dbb 100644
--- a/.github/workflows/new-prs.yml
+++ b/.github/workflows/new-prs.yml
@@ -16,7 +16,7 @@ on:
jobs:
greeter:
- runs-on: ubuntu-latest
+ runs-on: ubuntu-24.04
permissions:
pull-requests: write
# Only comment on PRs that have been opened for the first time, by someone
@@ -56,7 +56,7 @@ jobs:
automate-prs-labels:
# Greet first so that only the author gets that notification.
needs: greeter
- runs-on: ubuntu-latest
+ runs-on: ubuntu-24.04
# Ignore PRs with more than 10 commits. Pull requests with a lot of
# commits tend to be accidents usually when someone made a mistake while trying
# to rebase. We want to ignore these pull requests to avoid excessive
diff --git a/.github/workflows/pr-code-format.yml b/.github/workflows/pr-code-format.yml
index a5a5626369bdb..0692455ae0345 100644
--- a/.github/workflows/pr-code-format.yml
+++ b/.github/workflows/pr-code-format.yml
@@ -11,7 +11,7 @@ on:
jobs:
code_formatter:
- runs-on: ubuntu-latest
+ runs-on: ubuntu-24.04
timeout-minutes: 30
concurrency:
group: ${{ github.workflow }}-${{ github.event.pull_request.number }}
diff --git a/.github/workflows/pr-request-release-note.yml b/.github/workflows/pr-request-release-note.yml
index 2fa501dda16bb..57425e04ec2f4 100644
--- a/.github/workflows/pr-request-release-note.yml
+++ b/.github/workflows/pr-request-release-note.yml
@@ -14,7 +14,7 @@ jobs:
github.repository_owner == 'llvm' &&
startsWith(github.ref, 'refs/heads/release')
- runs-on: ubuntu-latest
+ runs-on: ubuntu-24.04
steps:
# We need to pull the script from the main branch, so that we ensure
# we get the latest version of this script.
diff --git a/.github/workflows/pr-subscriber.yml b/.github/workflows/pr-subscriber.yml
index 0e3d3e04ee938..f558da8a8fe0e 100644
--- a/.github/workflows/pr-subscriber.yml
+++ b/.github/workflows/pr-subscriber.yml
@@ -10,7 +10,7 @@ permissions:
jobs:
auto-subscribe:
- runs-on: ubuntu-latest
+ runs-on: ubuntu-24.04
if: github.repository == 'llvm/llvm-project'
steps:
- name: Checkout Automation Script
diff --git a/.github/workflows/release-documentation.yml b/.github/workflows/release-documentation.yml
index bac500080f90a..5a0aa063d32ac 100644
--- a/.github/workflows/release-documentation.yml
+++ b/.github/workflows/release-documentation.yml
@@ -29,7 +29,7 @@ on:
jobs:
release-documentation:
name: Build and Upload Release Documentation
- runs-on: ubuntu-latest
+ runs-on: ubuntu-24.04
env:
upload: ${{ inputs.upload && !contains(inputs.release-version, 'rc') }}
steps:
diff --git a/.github/workflows/release-doxygen.yml b/.github/workflows/release-doxygen.yml
index 17d437e3a649d..d47c4337c07b2 100644
--- a/.github/workflows/release-doxygen.yml
+++ b/.github/workflows/release-doxygen.yml
@@ -33,7 +33,7 @@ on:
jobs:
release-doxygen:
name: Build and Upload Release Doxygen
- runs-on: ubuntu-latest
+ runs-on: ubuntu-24.04
permissions:
contents: write
env:
diff --git a/.github/workflows/release-lit.yml b/.github/workflows/release-lit.yml
index 346cf3bf2c460..9adeffb74d52a 100644
--- a/.github/workflows/release-lit.yml
+++ b/.github/workflows/release-lit.yml
@@ -25,7 +25,7 @@ on:
jobs:
release-lit:
name: Release Lit
- runs-on: ubuntu-latest
+ runs-on: ubuntu-24.04
steps:
- name: Checkout LLVM
uses: actions/checkout at b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
diff --git a/.github/workflows/release-sources.yml b/.github/workflows/release-sources.yml
index a6c86823f99df..99438918b56f0 100644
--- a/.github/workflows/release-sources.yml
+++ b/.github/workflows/release-sources.yml
@@ -47,7 +47,7 @@ jobs:
outputs:
ref: ${{ steps.inputs.outputs.ref }}
export-args: ${{ steps.inputs.outputs.export-args }}
- runs-on: ubuntu-latest
+ runs-on: ubuntu-24.04
steps:
- id: inputs
run: |
@@ -63,7 +63,7 @@ jobs:
release-sources:
name: Package Release Sources
if: github.repository_owner == 'llvm'
- runs-on: ubuntu-latest
+ runs-on: ubuntu-24.04
needs:
- inputs
permissions:
diff --git a/.github/workflows/release-tasks.yml b/.github/workflows/release-tasks.yml
index 52076ea1821b0..d55098345d89e 100644
--- a/.github/workflows/release-tasks.yml
+++ b/.github/workflows/release-tasks.yml
@@ -12,7 +12,7 @@ on:
jobs:
validate-tag:
name: Validate Tag
- runs-on: ubuntu-latest
+ runs-on: ubuntu-24.04
if: github.repository == 'llvm/llvm-project'
outputs:
release-version: ${{ steps.validate-tag.outputs.release-version }}
@@ -26,7 +26,7 @@ jobs:
release-create:
name: Create a New Release
- runs-on: ubuntu-latest
+ runs-on: ubuntu-24.04
permissions:
contents: write # For creating the release.
needs: validate-tag
diff --git a/.github/workflows/scorecard.yml b/.github/workflows/scorecard.yml
index ff61cf83a6af3..db741b6405962 100644
--- a/.github/workflows/scorecard.yml
+++ b/.github/workflows/scorecard.yml
@@ -21,7 +21,7 @@ permissions:
jobs:
analysis:
name: Scorecard analysis
- runs-on: ubuntu-latest
+ runs-on: ubuntu-24.04
if: github.repository == 'llvm/llvm-project'
permissions:
# Needed to upload the results to code-scanning dashboard.
diff --git a/.github/workflows/version-check.yml b/.github/workflows/version-check.yml
index 18e21a1a8f295..a0a598094376f 100644
--- a/.github/workflows/version-check.yml
+++ b/.github/workflows/version-check.yml
@@ -14,7 +14,7 @@ permissions:
jobs:
version_check:
if: github.repository_owner == 'llvm'
- runs-on: ubuntu-latest
+ runs-on: ubuntu-24.04
steps:
- name: Fetch LLVM sources
uses: actions/checkout at 11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
More information about the llvm-commits
mailing list