[llvm] [llvm-strip] Let llvm-strip continue on encountering an error (PR #129531)

[James Henderson via llvm-commits]

================
@@ -0,0 +1,23 @@
+## Checks that llvm-strip continues to strip objects after encountering a bad
+## one while emitting an error for each bad one.
+
+# RUN: echo "bad" > %t1
+# RUN: yaml2obj %s -o %t2
+# RUN: not llvm-strip %t1 %t2 2>&1 | FileCheck %s --check-prefix=ERROR
+
+# ERROR: error: {{.*}}: The file was not recognized as a valid object file
+
+# RUN: llvm-readobj --sections %t2 | FileCheck %s --check-prefix=DEBUG
+
+# DEBUG-NOT: .debugGlobal
----------------
jh7370 wrote:

I'm always a bit nervous seeing a check pattern that is solely "NOT" based, as it is very easy for the check to go stale without any failure occurring.

An alternative approach would be to add `--strip-sections` to the llvm-strip command, which should remove all section headers. You can then use llvm-readobj to dump the file header and show that there are zero sections by checking the corresponding field. Other ideas are of course also possible, e.g. just checking the whole section name list.

https://github.com/llvm/llvm-project/pull/129531