[compiler-rt] [RTSan][Apple] Disable AccessingALargeAtomicVariableDiesWhenRealtime (PR #129309)
Chris Apple via llvm-commits
llvm-commits at lists.llvm.org
Fri Feb 28 15:53:26 PST 2025
cjappl wrote:
Yes, I will report back with a minimal binary by the end of the day that should repro the problem. (APAC timezone right now)
Hopefully hooking that binary up to Instruments or similar on the machine with the failure will point us right there.
On Sat, Mar 1, 2025 at 7:03 AM, thetruestblue ***@***.***(mailto:On Sat, Mar 1, 2025 at 7:03 AM, thetruestblue <<a href=)> wrote:
>> Hi ***@***.***(https://github.com/thetruestblue), I think ideally we would hunt down and figure out why this is failing to die. Both of the main RTSan devs work on macs primarily, and this test has always passed for us locally. Is it possible to figure out what kind of lock is being taken by the 'not is_lock_free' large atomic, and intercept that? That would be preferable to disabling the test.
>> […](#)
>> On Sat, Mar 1, 2025 at 6:16 AM, thetruestblue @.(mailto:On Sat, Mar 1, 2025 at 6:16 AM, thetruestblue <[wrote: @.]())(https://github.com/thetruestblue) requested your review on: #129309 [RTSan][Apple] Disable AccessingALargeAtomicVariableDiesWhenRealtime. — Reply to this email directly, [view it on GitHub]([#129309 (comment)](https://github.com/llvm/llvm-project/pull/129309#event-16517995685)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/ADMDXY3WUO2HPL52U6G2WOT2SDG37AVCNFSM6AAAAABYDF3DZSVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJWGUYTOOJZGU3DQNI). You are receiving this because your review was requested.Message ID: @.***>
>
> I agree it would be ideal to hunt this down and get the correct interceptor set up. Unfortunately, this has been failing in our CI for a few weeks now. Would it be possible to use the failing test above to try and get set up for a repro? We are currently resource constrained to dig into rtsan support currently, but need to clean up the CI.
>
> —
> Reply to this email directly, [view it on GitHub](https://github.com/llvm/llvm-project/pull/129309#issuecomment-2691621960), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/ADMDXYYJQ3DL5QJXQWTUEA32SDMLRAVCNFSM6AAAAABYDF3DZSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMOJRGYZDCOJWGA).
> You are receiving this because your review was requested.Message ID: ***@***.***>
>
> [thetruestblue] thetruestblue left a comment [(llvm/llvm-project#129309)](https://github.com/llvm/llvm-project/pull/129309#issuecomment-2691621960)
>
>> Hi ***@***.***(https://github.com/thetruestblue), I think ideally we would hunt down and figure out why this is failing to die. Both of the main RTSan devs work on macs primarily, and this test has always passed for us locally. Is it possible to figure out what kind of lock is being taken by the 'not is_lock_free' large atomic, and intercept that? That would be preferable to disabling the test.
>> […](#)
>> On Sat, Mar 1, 2025 at 6:16 AM, thetruestblue @.(mailto:On Sat, Mar 1, 2025 at 6:16 AM, thetruestblue <[wrote: @.]())(https://github.com/thetruestblue) requested your review on: #129309 [RTSan][Apple] Disable AccessingALargeAtomicVariableDiesWhenRealtime. — Reply to this email directly, [view it on GitHub]([#129309 (comment)](https://github.com/llvm/llvm-project/pull/129309#event-16517995685)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/ADMDXY3WUO2HPL52U6G2WOT2SDG37AVCNFSM6AAAAABYDF3DZSVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJWGUYTOOJZGU3DQNI). You are receiving this because your review was requested.Message ID: @.***>
>
> I agree it would be ideal to hunt this down and get the correct interceptor set up. Unfortunately, this has been failing in our CI for a few weeks now. Would it be possible to use the failing test above to try and get set up for a repro? We are currently resource constrained to dig into rtsan support currently, but need to clean up the CI.
>
> —
> Reply to this email directly, [view it on GitHub](https://github.com/llvm/llvm-project/pull/129309#issuecomment-2691621960), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/ADMDXYYJQ3DL5QJXQWTUEA32SDMLRAVCNFSM6AAAAABYDF3DZSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMOJRGYZDCOJWGA).
> You are receiving this because your review was requested.Message ID: ***@***.***>
https://github.com/llvm/llvm-project/pull/129309
More information about the llvm-commits
mailing list