[llvm] b2525dc - [MCA] Avoid repeated hash lookups (NFC) (#129192)

[via llvm-commits]

Author: Kazu Hirata
Date: 2025-02-28T08:04:26-08:00
New Revision: b2525dc66379f2c9942ed3cff6101b035003532c

URL: https://github.com/llvm/llvm-project/commit/b2525dc66379f2c9942ed3cff6101b035003532c
DIFF: https://github.com/llvm/llvm-project/commit/b2525dc66379f2c9942ed3cff6101b035003532c.diff

LOG: [MCA] Avoid repeated hash lookups (NFC) (#129192)

Added: 
    

Modified: 
    llvm/lib/MCA/InstrBuilder.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/MCA/InstrBuilder.cpp b/llvm/lib/MCA/InstrBuilder.cpp
index 2cb1908695308..2bac99b6309af 100644
--- a/llvm/lib/MCA/InstrBuilder.cpp
+++ b/llvm/lib/MCA/InstrBuilder.cpp
@@ -634,16 +634,14 @@ InstrBuilder::createInstrDescImpl(const MCInst &MCI,
   bool IsVariadic = MCDesc.isVariadic();
   if ((ID->IsRecyclable = !IsVariadic && !IsVariant)) {
     auto DKey = std::make_pair(MCI.getOpcode(), SchedClassID);
-    Descriptors[DKey] = std::move(ID);
-    return *Descriptors[DKey];
+    return *(Descriptors[DKey] = std::move(ID));
   }
 
   auto VDKey = std::make_pair(hashMCInst(MCI), SchedClassID);
   assert(
       !VariantDescriptors.contains(VDKey) &&
       "Expected VariantDescriptors to not already have a value for this key.");
-  VariantDescriptors[VDKey] = std::move(ID);
-  return *VariantDescriptors[VDKey];
+  return *(VariantDescriptors[VDKey] = std::move(ID));
 }
 
 Expected<const InstrDesc &>