[clang] [llvm] [Coroutines] Replace coro.outside.frame metadata with an intrinsic (PR #129255)

via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 28 06:49:07 PST 2025


github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff 71389e565db6c4f9b5b4515baaf711271ed29877 c1fe663ceacd31064b2758e43de1afc3f51d3f2c --extensions cpp,h -- clang/lib/CodeGen/CGCoroutine.cpp clang/test/CodeGenCoroutines/coro-gro.cpp clang/test/CodeGenCoroutines/coro-params.cpp llvm/include/llvm/Transforms/Coroutines/CoroInstr.h llvm/include/llvm/Transforms/Coroutines/CoroShape.h llvm/lib/Transforms/Coroutines/CoroSplit.cpp llvm/lib/Transforms/Coroutines/Coroutines.cpp llvm/lib/Transforms/Coroutines/SpillUtils.cpp llvm/lib/Transforms/Utils/PromoteMemoryToRegister.cpp
``````````

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/llvm/lib/Transforms/Coroutines/SpillUtils.cpp b/llvm/lib/Transforms/Coroutines/SpillUtils.cpp
index bfe22699f6..879bb3bae5 100644
--- a/llvm/lib/Transforms/Coroutines/SpillUtils.cpp
+++ b/llvm/lib/Transforms/Coroutines/SpillUtils.cpp
@@ -414,11 +414,10 @@ private:
 };
 } // namespace
 
-static void collectFrameAlloca(AllocaInst *AI, const coro::Shape &Shape,
-                               const SuspendCrossingInfo &Checker,
-                               SmallVectorImpl<AllocaInfo> &Allocas,
-                               const DominatorTree &DT,
-                               const SmallPtrSetImpl<Value*> &OutsideFrameSet) {
+static void collectFrameAlloca(
+    AllocaInst *AI, const coro::Shape &Shape,
+    const SuspendCrossingInfo &Checker, SmallVectorImpl<AllocaInfo> &Allocas,
+    const DominatorTree &DT, const SmallPtrSetImpl<Value *> &OutsideFrameSet) {
   if (Shape.CoroSuspends.empty())
     return;
 
@@ -464,7 +463,7 @@ void collectSpillsAndAllocasFromInsts(
     const SuspendCrossingInfo &Checker, const DominatorTree &DT,
     const coro::Shape &Shape) {
 
-  SmallPtrSet<Value*, 4> OutsideFramePtrs;
+  SmallPtrSet<Value *, 4> OutsideFramePtrs;
   for (const CoroOutsideFrameInst *I : Shape.OutsideFrames)
     OutsideFramePtrs.insert(I->getPtr());
 

``````````

</details>


https://github.com/llvm/llvm-project/pull/129255


More information about the llvm-commits mailing list