[llvm] [AMDGPU][NFC] Use a worklist and remember results (PR #129175)

[Jay Foad via llvm-commits]

================
@@ -257,26 +259,43 @@ class AMDGPUInformationCache : public InformationCache {
   }
 
   /// Get the constant access bitmap for \p C.
-  uint8_t getConstantAccess(const Constant *C,
-                            SmallPtrSetImpl<const Constant *> &Visited) {
-    auto It = ConstantStatus.find(C);
+  uint8_t getConstantAccess(const Constant *C) {
+    const auto &It = ConstantStatus.find(C);
     if (It != ConstantStatus.end())
-      return It->second;
+      return It->second.value();
 
-    uint8_t Result = 0;
-    if (isDSAddress(C))
-      Result = DS_GLOBAL;
+    SmallPtrSet<const Constant *, 8> Visited;
+    SmallVector<const Constant *> Worklist;
+    Worklist.push_back(C);
+    Visited.insert(C);
 
-    if (const auto *CE = dyn_cast<ConstantExpr>(C))
-      Result |= visitConstExpr(CE);
+    uint8_t Result = 0;
+    while (Result != CS_WORST && !Worklist.empty()) {
+      const Constant *CurC = Worklist.pop_back_val();
 
-    for (const Use &U : C->operands()) {
-      const auto *OpC = dyn_cast<Constant>(U);
-      if (!OpC || !Visited.insert(OpC).second)
+      std::optional<uint8_t> &CurCResultOrNone = ConstantStatus[CurC];
----------------
jayfoad wrote:

Just a drive-by comment: This seems like a weird mixture of using the "optional" to detect whether CurC was already in the map, whereas on line 264 above you're still using the alternative find(C) == end() approach. I would suggest removing the "optional" and using `auto [Iter, Inserted] = ConstantStatus.insert` here.

https://github.com/llvm/llvm-project/pull/129175