[llvm] [llvm][ELF]Add Shdr check for getBuildID (PR #126537)

James Henderson via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 28 00:42:39 PST 2025


================
@@ -31,7 +30,61 @@ static Expected<ELFObjectFile<ELFT>> toBinary(SmallVectorImpl<char> &Storage,
   return ELFObjectFile<ELFT>::create(MemoryBufferRef(OS.str(), "dummyELF"));
 }
 
+static StringRef optionalSectionHeaderELF(bool WithSec) {
----------------
jh7370 wrote:

LLVM naming guidelines say that functions should be verbs or verb phrases. I also think it would be clearer if you called it something like `getInvalidNoteELF` and change the parameter to `WithShdr`, since it's slightly more explicit about what the code is doing.

https://github.com/llvm/llvm-project/pull/126537


More information about the llvm-commits mailing list