[llvm] [NVPTX][NVPTXLowerArgs] Add NewPM interface for NVPTXLowerArgs (PR #128960)

[Artem Belevich via llvm-commits]

================
@@ -571,8 +560,7 @@ void copyByValParam(Function &F, Argument &Arg) {
 }
 } // namespace
 
-void NVPTXLowerArgs::handleByValParam(const NVPTXTargetMachine &TM,
-                                      Argument *Arg) {
+static void handleByValParam(const NVPTXTargetMachine &TM, Argument *Arg) {
----------------
Artem-B wrote:

That advise (at least the part about indentation) appears to predate widespread use of clang-format.
While `static` indeed makes it easier to determine locality, it does not buy us much in a largely self-contained file which implements a pass. If we were to implement a general purpose library providing many freestanding functions, that would be a different story. In practice, I don't think I've ever seen any push back on use of the anonymous namespaces.

In this particular case, inconsistently using `static` for some functions, but anonymous namespace for others makes things look worse.

My preference would be to stick with the existing style and continue using anonymous namespace. Switching to static just does not buy us anything here, IMO. 



https://github.com/llvm/llvm-project/pull/128960